I've tried to use thickbox with node images but nothing really happens. It seems to be caused by the fact that the current version of node_images does not give the "image" and "thumbnail" classes to its thumbs. I've managed to arrange this by hacking the node_images.module, adding the right classes, but then the problem becomes that node_images is still popping-up a window. We should be able to override the onclick="window.open..." call, but I don't know jquery well enough to do that (besides, we shouldn't touch the node_images.module anyhow unless necessary).

Comments

frjo’s picture

frjo commented
Category: bug » feature

I have never used the node_images module but if someone provide a good patch I will take a look at it.

kleingeist’s picture

kleingeist commented
Category: feature » bug

i can confirm this behaviour with the latest HEAD version of the image module. They had a request to change the class due to theming problems: http://drupal.org/node/133127

The changes have been made in revision 1.228, http://cvs.drupal.org/viewcvs/drupal/contributions/modules/image/image.m...
and will be in the official package soon.

What should we do?

We could change the thickbox_auto.js code to match the new class:
$("a[img.image-thumbnail]", context).not(".thickbox").not(".category").each(function(i) {
But that will break every installation, which is not using the latest image.module

frjo’s picture

frjo commented
Status: Active » Fixed

I went ahed and committed this change, it part of the latest official release of image module.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)