Closed (fixed)
Project:
Image Assist
Version:
5.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Feb 2007 at 10:16 UTC
Updated:
23 Mar 2007 at 02:17 UTC
Steps:
Image assist module should display inside the Image module table instead it is displaying in the other categories table. Screen shots attached
| Comment | File | Size | Author |
|---|---|---|---|
| snapshot7.png | 75.66 KB | Sunil Patel |
Comments
Comment #1
zoo33 commentedI agree that it would be nice to have Image assist appear below "Image". In fact, that was the way we did it at first in the Drupal 5 port. However, it was agreed not to assign it to "Image" because the idea behind those "categories", or "packages" as they're actually called, is to group modules that belong to just that, a package. The "Image" package exists because there are three modules distributed with the Image module, thus forming a package. Image assist is not actually part of a package in that sense, but one might argue that it should belong to "Image" anyway, since it's unusable without the Image module.
This is what seems to be the consensus on the development mailing list (webchick's words):
And the handbook says:
So, I'd say we could probably use the Image package after all. Any objections?
Comment #2
moonray commentedWe went through this in regards to the taxonomy list module. The final verdict was (after a lot of back and forth with the developer mailing list) that a package should only be assigned when it's a real package, not to group modules that depend on other packages. See #101980 and the developer mailing list, circa December 20th.
Comment #3
zoo33 commentedIt's a tricky question. I don't think the consensus is really that solid even among core developers, except that everyone agrees that Packages are not Categories.
In the case of Image assist I think it really wouldn't be that big a deal to assign it to Image since that package already exists. This is really a sub-module to Image, don't you think? The Taxonomy case is different in my mind at least because it's such a huge concept which applies to so many different things.
If you take CCK, which everyone seems to agree is a valid package, it consists of both the modules that are distributed with the main project (e.g. the Content and Text modules) as well as contributed modules (e.g. Imagefield) that use the same foundation but belong to a different project. Doesn't the same apply to Image, Image gallery and Image attach on the one hand and Image assist on the other?
@moonray: I think you probably agree with this, except maybe it's not 100% in line with what some people think. I don't think there is a policy that stops us from doing this however – Dries said in an email to the dev list that he doesn't want to have too strict rules about packages. I think that handbook text is as close as we'll get to an official policy.
Comment #4
moonray commentedIf you feel comfortable with it, I would say go for it. Just keep in mind that there was some talk of revamping the modules page to allow for categories in addition to packages. That wouldn't happen until drupal 6, though.
It makes sense for image assist to be part of the image package, in my book. :-)
Comment #5
zoo33 commentedIf we do this, then there would have to be an Image assist package. Maybe we should wait for a while and see what happens.
Comment #6
zoo33 commentedHm, it seems that this module was already moved to Image in this commit on February 20th – six days before this issue was created. Well, it was nice discussing it anyway... :)
Comment #7
(not verified) commented