Popup browser broken when using "Add another item" on multiple field

Patch tested here and it did the trick, no more terrible popup behavior.

I confirm the patch is working great and the code looks good. It was not applying anymore, so here is a simple reroll.

Patch works for me too, thanks. Maybe we should add a small comment in the code to explain the changes here?

Here is the same patch as above with added comment. I've chosen to use a shortened version of the current issue title: fix broken popup browser when using "add another item"

Here's a patch so you're not hardcoding zero into the index, and putting a check to make sure the array is not empty just so the code can be bullet proof.

Fixed a few more spacing issues.

nice, thanks guys

Found one more space issue and simplified the code a little.

I still kinda like the if statements broken out, means it doesn't have to evaluate two, just one before anything else goes on. I think at this point though stuff like this is trvial

I think we should go with patch in #7

LSU_JBob, the patch in #9 does the exact same thing. If the first condition for the if evaluates to false, that value will be returned and the second condition will be ignored. I see no reason to split it into two ifs.

The patch in #9 looks good. Just one suggestion maybe, why not use the jQuery.isArray() function? I think it makes the code more clear.

Here is a patch identical as #9, except that it uses the $.isArray function.
ref: http://api.jquery.com/jQuery.isArray/

One minute after I posted the last patch I thought about one more simplification. Since we assign options.widget.src to browserSrc we can use that variable for the condition and value assignment too.

Nice. Now we just need the maintainers to take a look at it.

Works for me. Let's get this committed!

Thanks for the patch, I used #13 and it seems to have fixed the issue.

The patch in #13 is dead simple. Let's get it in as this bug will effect a lot of users.

I tested the patch in #13 and it does not work for me. I'm using the Rubik theme, not sure if that would make a difference. I went back to the very first patch posted and had success with that.

@rickvug: what browser are you using?

@idflood Chrome 13 for Mac.

I've tried to reproduce the issue described in #18 without luck. Tested on chrome 13 on osx, with first and last patch and they are both working. Tried again after insalling tao and rubick with rubick as the admin theme, and both patches are still working.

The important thing is that one of these patch get commited. Then it will be easier to fix edge cases.

@rickvug: Any idea of other modules / changes you made that may affect the result?

Subscribe

Subscribing!will test the patch later

@rootatwc @idflood Sorry that I haven't been able to get back to testing again. If you can't reproduce the problem feel free to commit the patch. If the problem crops up for me again I'll comment further.

Tested and works with both chrome and firefox in Linux!
As per #24,Please commit this!

Also tested it against 7.x-1.x.works there too!!
Can someone commit it on both branches?its an anoying bug:p

The issue still exists in 7.x-2.x. The patch in #13 still apply and fix it. please commit

Committed #13 to both branches. Thanks!
http://drupalcode.org/project/media.git/commit/1748396
http://drupalcode.org/project/media.git/commit/1d9bdfe