Support File entities and file, image and media fields

Hi, I have just started to play with uuid_features after trying Default Content and I find that uuid_features takes a more generic approach.

Exporting files is a very useful addition indeed, but even with this patch applied we still need to copy the files/ dir manually right? I can't see actual files in the feature archive when I export their drupal representation.

Thanks,
Antonio

OK, so if I get it the workflow should be:

1. Create a feature (e.g. default_content)
2. Install that very feature, AFAICS when a new feature is created it is not installed automatically
3. Run drush ufuf default_content to copy the actual files in the directory of the feature above
4. Repack the feature archive for distribution
5. Install the feature on another site (or on site reinstall for example: I am using drush make to rebuild the site after each feature is complete).

This seems to work well with some minor glitches:

• drush ufuf wants to depend on filefield, I had to change that:

  diff --git a/includes/uuid_features.drush.inc b/includes/uuid_features.drush.inc
  index c5182e1..c82a5d4 100644
  --- a/includes/uuid_features.drush.inc
  +++ b/includes/uuid_features.drush.inc
  @@ -22,7 +22,7 @@ function uuid_features_drush_command() {
       'arguments' => array(
         'feature' => 'Feature name to export.',
       ),
  -    'drupal dependencies' => array('features', 'uuid', 'uuid_features', 'filefield'),
  +    'drupal dependencies' => array('features', 'uuid', 'uuid_features', 'file'),
       'aliases' => array('ufuf'),
     );
   
  

• When installing the feature on a new site there are some warnings:
  

  $ drush en default_content
  The following extensions will be enabled: default_content
  Do you really want to continue? (y/n): y
  WD php: Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of       [warning]
  /home/ao2/public_html/mysite/includes/entity.inc).
  default_content was enabled successfully.                                                                                           [ok]
  array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of                     [warning]
  /home/ao2/public_html/mysite/includes/entity.inc).
  

But it is very promising, thanks @fabsor.

there is a little mistake in this patch:
function uuid_file_features_export.

   foreach ($data as $uuid) {
    if (isset($map[$identifier]) && $map[$identifier] != $module_name) {
      if (isset($export['features']['uuid_file'][$uuid])) {
        unset($export['features']['uuid_file'][$uuid]);
      }
      $export['dependencies'][$module] = $map[$identifier];
    }
    else {
      $export['features']['uuid_file'][$uuid] = $uuid;
    }
   }

must be

   foreach ($data as $uuid) {
    if (isset($map[$uuid]) && $map[$uuid] != $module_name) {
      if (isset($export['features']['uuid_file'][$uuid])) {
        unset($export['features']['uuid_file'][$uuid]);
      }
      $export['dependencies'][$module] = $map[$uuid];
    }
    else {
      $export['features']['uuid_file'][$uuid] = $uuid;
    }
   }

Hi there - are you still working on this?

Attempt at a reroll without a deep understanding of the code, and accounting for #6

Oops. And here's the file.

Oops again, and this one also has the change from #5 to fix drush ufuf

:( And here is a file with actual stuff in it.

Doesn't seem to actually work.

It seems this patch is using obsolete uuid_file_find(), instead one could use this for example:

$files = array_values(entity_uuid_load('file', array($uuid)));
$fid = $files[0]->fid;

I'm sure it can be done prettier, but this works(tm)! It's however not the whole story:
- one should use the dev version of uuid_featrues
- apply patch from #12
- edit like shown above (replace all occurences of uuid_file_find that is
- in your feature choose recreate, and uncheck and recheck an entry under node(uuid), file entities should now be picked up
- save and deploy your updated feature
- run "drush uuid-features-update-files %your feature%"

You should now have a feature with embedded files to deploy on another install.

Hope this helps!

Rerolled patch from #12 with changes suggested in #14

Should I use drush for working this module now?

I need to export my cck imagefield content with my feature.

Confirm #15 able to apply to latest 7.x-1.x-dev together with following issues:

• #1229670: Support File entities and file, image and media fields
• #1812876: Exported nodes are referred to term [tid] instead of [uuid]?
• #2051915: uuid_term should optionally depend on other features export, not hard code with vocabulary export
• #2052387: Undefined property: stdClass::$nid in DrupalDefaultEntityController->load()
• #2060587: Split variables as entity type specific

It is now applied to DruStack 7.x-23.x and I will detail confirm if it works as expected

Hi all,

Nice effort so far on this issue. Unfortunately, alone, the patch in #15 doesn't appear to work. While the file entity is recreated properly, the reference to it from within a node body is still pointing to the original Field ID:

[[{"fid":"8","view_mode":"default", ...

When reverting the feature, it tries to revert the node first and then the file. So I tried reverting the file field first, then the node, but still no luck.

There's also a minor E_STRICT warning, but that's really just a coding style thing, and using a temporary variable clears it up:

Strict warning: Only variables should be passed by reference in uuid_file_features_export_render() (line 70 of /var/aegir/platforms/oatest/sites/all/modules/uuid_features/includes/uuid_file.features.inc).

Revised patch which added null checking to avoid errors when file doesn't exist.

@ergonlogic: The reason it doesn't work with reference in body is because of #2117453: uuid_node doesn't use entity_uuid_load/save to load/save node

didnt apply anymore so i rerolled

http://www.php.net/manual/en/language.references.pass.php

to avoid strict php notices we should pass this as a variable since
The following things can be passed by reference:

• Variables, i.e. foo($a)
• New statements, i.e. foo(new foobar())
• References returned from functions

$fileextension = explode('.', $file->filename);
array_pop($fileextension);

The newest dev version of this module no longer seems to export media field data in features. This worked just fine in alpha4.

Re-rolled the patch from #20 to apply against latest head.

#24 still results in the following warning when viewing the feature:
Strict warning: Only variables should be passed by reference in uuid_file_features_export_render() (line 74 of /sites/all/modules/contrib/uuid_features/includes/uuid_file.features.inc).

This also seems new:

WD node: EntityMalformedException: Missing bundle property on entity of type node. in entity_extract_ids() (line 7783 of /includes/common.inc).[error]
<h1>Uncaught exception thrown in shutdown function.</h1><p>EntityMalformedException: Missing bundle property on entity of type node. in entity_extract_ids() (line 7783 of /includes/common.inc).</p><hr />

Adding the files via "file" in features now works in bringing that actual files along, but images are still not being attached to nodes on feature revert. The feature is listed as overridden and wants to remove the image field value from itself because it is empty.

Update: This last part seems to be caused by the fid being inserted in my_feature.features.uuid_node.inc, which makes sense because the file in the feature does not have an fid associated with it. Removing this value and reverting the feature seems to work, so the patch should probably be altered to exclude this value, as the whole point of uuid is so that you don't need an fid. The errors are still present, though.

The problem seems to be in uuid_node.features.inc:

  // Don't cause conflicts with nid/vid/revision_timestamp/changed fields.
  uuid_features_file_field_export($export, 'node');

  $entity_type = 'node';
  drupal_alter('uuid_entity_features_export_render', $entity_type, $export, $node, $module);
  drupal_alter('uuid_node_features_export_render', $export, $node, $module);

uuid_features_file_field_export() is where the fid stripping occurs, but after this is done, uuid_entity_features_export_render puts them back in the $export variable. Is it safe to simply flip the order of these things? such as in:

  $entity_type = 'node';
  drupal_alter('uuid_entity_features_export_render', $entity_type, $export, $node, $module);
  drupal_alter('uuid_node_features_export_render', $export, $node, $module);

  // Don't cause conflicts with nid/vid/revision_timestamp/changed fields.
  uuid_features_file_field_export($export, 'node');

I don't really know the full implications of this, but it seems to fix the problem. If this is not okay, then the fid stripping functionality needs to reproduced in uuid_entity_features_export_render. There's a lot going on here, and it seems that there might be some redundancy in the code.

Either that, or if these are two different options, there needs to be some logic to determine which to execute.

So, I just discovered what seem to be hidden UUID Features settings which, combined with the file_entity module (which I was already using), seem to make all of these patches unnecessary, for the dev build of this module as of today. Simply making file entities exportable on admin/structure/features/uuid_features works just fine. no patches to uuid_features necessary. I may just be blind, but the only link I could find to that page is from admin/modules, which is why I didn't see it before and started trying all of these recent patches that seem to be doing nothing but breaking things and causing errors.

If anyone else is in the same boat, I recommend trying these settings and exporting them as well. Solved all my problems.

+1 to #26, specific entities should go second

Re-rolled #24 against latest -dev to include suggestion from #26.

Seems to work in my case...

Hrm.. doesn't seem to work against latest uuid / uuid_features with either the base64 / packaged files option.

First part of the problem solved by fixing the check for exportable file types in includes/uuid_file_entity.features.inc

With this patch, I can see the files under "File Entity" section of the feature creation form, but the actual files are not included in the generated module when packaged in assets (it does get included as inline base64, but the module can get really big).

Getting closer...

This new patch works with packaged files in my case. More testing needed though...

conflicts with Usage filter for files

Which is a better approach?

My previous patch had a problem with missing files in the assets folder, as only the last file would be included.

This is an updated version of this patch, which doesn't address the conflict mentioned by @SocialNicheGuru.

Using the patch in #36 was fantastic! Solved my issue perfectly.

Not sure if this is the right place for this but I've modified the patch in exclude the user_uuid from the file_entity export. This is causing my feature to always appear overridden when deployed to a different site or environment.

#41. This does not fix the issue I'm having.

Patch #36 works perfectly!

Provided new patch to fix coding standard issues based on patch #36.

The following issue Fatal error: Class 'ServicesWebTestCase' not found when visiting drupal testing page Primary tabs View(active tab) will fix the problem with tests failure.