I'm having all sorts of weird issues with this module - not sure if it's a conflict with taxonomy_themes or some other module. Any suggestions would be really helpful - I've used this module on 4.7 sites with no issues.

1) The module seems to ignore the node exclude/include settings.

2) If I check "Show current term in breadcrumb trail?" - The terms of my heaviest weighted vocabulary appear in the breadcrumb for all pages - even though this vocabulary is only enabled for a single node type. These terms even appear on admin pages (that don't have vocabularies).

3) Weirdest of all, I get 5 sequential php error messages in my log if I click the link to the "view" page I've created as the administrator-defined page associated with one of the two terms in this vocabulary. The views page displays fine - I don't see why this error message is being created:

array_pop() [function.array-pop]: The argument should be an array in /../../drupal/sites/all/modules/taxonomy_breadcrumb/taxonomy_breadcrumb.module on line 125.

Any advice out there? Sorry for a somewhat vague cry for help. I'm guessing that this is something particular to my setup rather than a bug.

Thanks,
Sean

Comments

seanberto’s picture

seanberto commented

Okay, Follow-up.

I think that I've identified the problem with the views page creating the array error. This may actually be a bug. I currently have no "home" breadcrumb and have deselected "Show current term in breadcrumb trail?". As a result, I'm guessing that $breadcrumb is empty, so when the views page is loaded, it passes a null value to line 125 in taxonomy_breadcrumb.module:

  // Remove current TERM from end of breadcrumb trail
  if (!variable_get('taxonomy_breadcrumb_show_current_term', TRUE)) {
    array_pop($breadcrumb);
  }
  return $breadcrumb;

Further proof, I can stop this error by either adding a "home" breadcrumb or selecting "Show current term in breadcrumb trail?".

On a separate note, I'm still having issues with the module settings not being saved correctly. If I enter a "home" breadcrumb and save it, and then go back and delete it, it still appears in the breadcrumb trail - unless I click "reset defaults."

Any thoughts out there?

-s

_craig’s picture

_craig commented

Q1a/b: Which PHP version are you using? What version of core?
Q2: What's the $Id: line say in taxonomy_breadcrumb.module?

Issue (3): Despite what the documentation says, array_php seems to have a problem in PHP 4 when the array is empty or not an array. Let me guess, are you using PHP4? I normally use PHP5 but tried out PHP4 to solve this one and noticed the same problem you did. See if adding this helps:

<?php
  if (!variable_get('taxonomy_breadcrumb_show_current_term', TRUE)) {  // Change FROM
  if (!variable_get('taxonomy_breadcrumb_show_current_term', TRUE) && !is_null($breadcrumb)) {  // Change TO
?>

Q3: Does this code change work? Let me know and I'll make an update to the module.
Q4: Assuming the code change works, are you still having problems with Issues (1) and (2)? I really don't have any idea on how the breadcrumbs can show up on the admin pages. The module only kicks in for nodes and /taxonomy/term/# pages.

seanberto’s picture

seanberto commented

Thanks for the follow-up. Unfortunately, since this is a production site I can't do too much testing, except on off-hours. I actually ended up disabling this module and went with a combination of views and custom breadcrumbs - though I've used tax breadcrumb on other sites and love it.

I'm running Drupal 5.1 on PHP5, with $Id: taxonomy_access.module,v 1.102.2.4 2007/02/17 11:56:34 keve Exp $.

The other thing that might be affecting this is that I did do a major upgrade from 4.6 to 5.1 a month ago. Maybe I've got something tweaky going on in the db.

Thanks again.
-s

_craig’s picture

_craig commented
Status: Active » Closed (fixed)

Also see http://drupal.org/node/128127.