Hi - first let me say that this module makes my entire website possible. Thank you for your important donation to the Drupal community!

I've gotten this on every page for a long time - not sure why it is. Any ideas or help would be great.

warning: array_pop() [function.array-pop]: The argument should be an array in /Applications/MAMP/htdocs/modules/taxonomy_breadcrumb/taxonomy_breadcrumb.module on line 135.

I looked at the module line 135. To shut up the error for right now, I just changed line 135 to this.

if(is_array($breadcrumb)){array_pop($breadcrumb);}

I'm guessing that if there's any chance of this variable changing you should be wrapping it anyway.

The question is: how does $breadcrumb become NOT an array?

Thanks again for your help and please let me know if I can be of further assistance.

Best regards -thejerz

Comments

_craig’s picture

_craig commented

Thanks for the feedback. It looks like you're seeing this too. For some reason it seems as if the PHP4 version of array_pop doesn't like an empty $breadcrumb. I am unable to duplicate this issue with PHP5.

I made a change to the 5.x branch. Try the latest out and let me know if it fixes the problem--then I'll issue a new release.

Thanks,
Craig

_craig’s picture

_craig commented
Status: Active » Needs review
thejerz’s picture

thejerz commented

Craig: this fixed the problem for me. Fantastic! Is there any specific testing you require?

-thejerz

_craig’s picture

_craig commented

Considering the size of the change that's good enough for me. I tested it, you tested it. I'll call that working. I rolled this out as version 5.x-1.4. Thanks for the help!

_craig’s picture

_craig commented
Status: Needs review » Closed (fixed)