I have configured the ShareThis Settings to show the buttons on Panel pages/nodes and yet when I try to insert the buttons into a panel, there is no option to do so.

CommentFileSizeAuthor
#29 1230146-29.am_.patch3.33 KBjherencia
#29 1230146-29.patch2.82 KBjherencia
#26 1230146-26.am_.patch3.33 KBjherencia
#26 1230146-26.patch2.82 KBjherencia
#22 1230146-22-am.patch3.26 KBjherencia
#22 1230146-22.patch2.79 KBjherencia
#20 1230146-am.patch1.82 KBjherencia
#20 1230146.patch1.34 KBjherencia
#17 Workbench_Moderation-Features-1314508-8.patch6.5 KBh00dwynk
#16 SharethisPanels-1230146-15.patch1.58 KBh00dwynk

Comments

markduce’s picture

markduce commented

Subscribing...

jvalencia’s picture

jvalencia commented

I'm slightly confused, could you outline what you did vs. what you expect to happen?
Thanks!

markduce’s picture

markduce commented

Sorry, I just put 'subscribing' so that when someone answers your question I get a notification as I don't know the answer

wcarpent’s picture

wcarpent commented

On my site, ShareThis buttons will appear on static pages as they would be expected to. However, I have a particular node type which is displayed through panels and I'm unable to display the ShareThis buttons on this node type or through the panels configuration. When I attempt to "add content" to a panel for this node type, I'm unable to add the ShareThis buttons. I would like to be able to put ShareThis buttons into a panel.

alonk27’s picture

alonk27 commented

Subscribing...

alonk27’s picture

alonk27 commented

I find it so hard to believe that no one knows anything about that. How can it be that something like "Share this" would not integrate with "Panels"??????

I'm searching for an answer for two weeks now...

Can anyone help?

Thanks.

jvalencia’s picture

jvalencia commented

I'm looking into it and have filed a support request with Panels

Any insight would be appreciated, as I'm not sure how to procede.

alonk27’s picture

alonk27 commented

Thank you.

7wonders’s picture

7wonders commented

You can do it the old fashioned way as a workaround.

1. Go here - http://sharethis.com/publishers/get-sharing-button and pick your button
2. Click get the button
3. Open up your theme html.tpl.php and put in the script in your head.
4. Put the span code in a mini panel custom code.
5. Add mini panel to panel.

Done.

alonk27’s picture

alonk27 commented

You have no idea how much you helped me. Thank you very much!!!! it is working!!!

courtney.mob’s picture

courtney.mob commented

subscribe

jvalencia’s picture

jvalencia commented
Status: Active » Needs review

7.2 branch addresses this. Look under miscellaneous when you add to panels, and add the ShareThis block.
Let me know if this works for you.

cwithout’s picture

cwithout commented

This worked in Panels for me in the 7.x-2.2 release.

But does not work in the current 7.x-2.x-dev.

jvalencia’s picture

jvalencia commented
Assigned: Unassigned » robloach
Anonymous’s picture

Anonymous (not verified) commented
Assigned: robloach » h00dwynk
Category: bug » task
Priority: Normal » Major
Status: Needs review » Active

Patch is coming soon to integrate with Panels.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new SharethisPanels-1230146-15.patch1.58 KB
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new Workbench_Moderation-Features-1314508-8.patch6.5 KB
Anonymous’s picture

Anonymous (not verified) commented

needs review :)

gumdrop’s picture

gumdrop commented
Version: 7.x-1.1 » 7.x-2.x-dev

Tried all patches and view 3 patch and still doesn't show in panels

jherencia’s picture

jherencia commented
StatusFileSize
new 1230146.patch1.34 KB
new 1230146-am.patch1.82 KB

@gumdrop please try this:

The AM patch is to apply with git am.

brunodbo’s picture

brunodbo
he/him
commented

Patch in #20 works for me, thanks!

Got a minor whitespace error on line 48 though - not sure how to fix that (when I tried to remove the extra line at the end, I got a 'patch corrupt' error and it wouldn't apply anymore.

jherencia’s picture

jherencia commented
StatusFileSize
new 1230146-22.patch2.79 KB
new 1230146-22-am.patch3.26 KB

I've improved the pane to be able to configure between:

  • Share global link
  • Share current URL
  • Share external link
jansenCreative’s picture

jansenCreative commented
luksak’s picture

luksak
he/him
commented

For a quick workaround you could just embed a view in your panel which displays the ShareThis links. This is how I solved it for the moment.

drupal_was_my_past’s picture

drupal_was_my_past commented

#22 didn't apply cleanly for me, but (when I manually applied the patch) it functionality is great.

jherencia’s picture

jherencia commented
StatusFileSize
new 1230146-26.patch2.82 KB
new 1230146-26.am_.patch3.33 KB

Rerolled.

rerooting’s picture

rerooting commented

Line #559 needs a / to open the comment block.

Otherwise, it works great! Thanks! When will this be rolled into a release?

bastos71’s picture

bastos71 commented

Hi everybody !

I'm working on a project and I would like to apply the patch. But how could I simply do it ?

Thank you for answers :)

jherencia’s picture

jherencia commented
StatusFileSize
new 1230146-29.patch2.82 KB
new 1230146-29.am_.patch3.33 KB

Thank you @rerooting :). Here is a new reroll.

rerooting’s picture

rerooting commented

@Bastos71 - you can wget it to the module root folder and do a few things:

patch -p1 < 1230146-29.patch

Is the old way which works well when you aren't controlling an individual repo for the module. Otherwise, you *should* be able to use git apply.

I don't know much about the git am method that folks are using for patches here, but I'm sure it's a good approach as well!

This resource has always been indispensable for me: http://drupal.org/patch/apply

rerooting’s picture

rerooting commented
Status: Needs review » Reviewed & tested by the community

I've used this several times, with the most recent minor tweak it works flawlessly. Is that enough for it to be RTBC? I think so. Would love to see this committed, meanwhile its going into several of my .make files!

Gaofengzzz’s picture

Gaofengzzz commented
Assigned: h00dwynk » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks very much @jherencia for your patch.
After more than two weeks, with no particular objections or further issues on this ticket, I went ahead and got it committed against the 7.x-2.x branch at d511cb7.

I allowed myself to re-roll this patch and mark this issue as fixed for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections with this patch (we would surely be happy to hear your feedback).

Special thanks to @wcarpent, @Valor, @rerooting for re-implementing, Re-rolling, testing this patch.

Thanks again to everyone for your help, reviews, feedback and comments on this issue.

Cheers!

rerooting’s picture

rerooting commented

Thanks for the commit! Just pulled it on a project, it appears I'm getting an AJAX error whenever I try to add the pane. Not sure what it's being caused by (hard to debug), I'll have to let you know what I figure out.

Anonymous’s picture

Anonymous (not verified) commented

So is this patch in the current (July 3, 2013) dev version on the Drupal site or not?

jherencia’s picture

jherencia commented

This patch is in the dev version of this module (https://drupal.org/project/sharethis) which is 7.x-2.x-dev (2013-Jun-26).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

user654’s picture

user654 commented

.

reallyordinary’s picture

reallyordinary commented
Version: 7.x-2.x-dev » 7.x-2.8
Issue summary: View changes
Status: Closed (fixed) » Active

This isn't working. Just set up on fresh D7.28 install with latest panels and latest 7.x-2.8 version of ShareThis module. Shows up fine when not using panels. When using a panels node view page, nope. Nothing.

EDIT: I take it back - right, you have to set Location to "block" in ShareThis settings. Then it shows up fine in panels. Apologies.

reallyordinary’s picture

reallyordinary commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.