Hello

I created a triggered rule, the event is set to "Node revision is going to be deleted".
When the pending revision is deleted, the rule is not fired.

The "Node revision is going to be published" event is working.

Thanks for any help and thanks for this awesome module!

Comments

alcoder’s picture

Title: "Rules: Node revision is going to be deleted" not working » Some Rule events are not working correctly

UPDATE:

The "Node revision is going to be published" event is also not working as it should.

If the moderator clicks on the "Publish This" button, the Rule will work correctly - the "Node revision is going to be published" event is generated.

But If the moderator wants to edit the pending revision and after editing he clicks on the save button and the revision is automatically published with the "Auto-publish drafts" functionality, then the "Node revision is going to be published" event is NOT generated!!

alcoder’s picture

I think I have found the solution to the "Node revision is going to be deleted" event bug

In revisioning.pages.inc file on line 208:
$return = module_invoke_all('revisionapi', 'pre revert', $node);

We should change the 'pre revert' to 'pre delete':
$return = module_invoke_all('revisionapi', 'pre delete', $node);

rdeboer’s picture

Yep! Good pick up, alcoder.
I will fix the other event too.
Rik

alcoder’s picture

Thanks Rik.

rdeboer’s picture

Assigned: Unassigned » rdeboer

Pushed patch of #2 onto the Git 6.x-3.x branch .

rdeboer’s picture

Version: 6.x-3.13 » 6.x-3.12
Status: Active » Fixed

Yep still available on 6.x-3.x. Will be part of next realease 6.x-3.14

rdeboer’s picture

Version: 6.x-3.12 » 6.x-3.13
Priority: Major » Normal

OOps... Accidentally changed version number.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Balbo’s picture

Status: Closed (fixed) » Active

#1 is not fixed.

rdeboer’s picture

D6 is approaching end of life. Doing maintenance fixes only.

rdeboer’s picture

Status: Active » Closed (won't fix)