[D7] Prettify

Hi egil,

I opened an issue in the project queue. Please set this back to "needs review" when that's fixed.

> description = This Drupal module is a unobtrusive input filters which enables syntax highlighting of source code snippets. The module uses the very popular google-code-prettify JavaScript library to do the highlighting.

I'm going to be reading this on the Drupal modules admin page. I kinda know I'm using Drupal already ;)

Also, HTML apparently works in this, but this seems like overkill. The link is a nice touch, but there's no need for the em or strongs. It should be also shorter, eg "Provides a syntax highlighting input filter using the google-code-prettify library."

> admin/config/prettify

In D7, your admin pages must go beneath admin/config/CATEGORY/, where ideally that is one of the existing ones.

> Warning message
Unable to locate prettify.js. Expected to find it in sites/all/libraries/google-code-prettify.

I got a warning rather than a fatal, which is good. But where do I find this library? Don't expect your users to read the readme before enabling the module. Though when they do...

> 2. Go to the google-code-prettify download page [gcp1] and
download the minified source files (e.g. prettify-small-1-Jun-2011.tar.bz2)
and unpack the downloaded file into your sites/all/libraries
(or sites/sitename/libraries) folder.

Is this style of putting URLs in footnotes still in use? It used to be used in emails and mailing lists IIRC because long urls got chopped off by email clients. But it's not the 90s any more :)

> The folder structure should look like this when you are done:
sites/all/libraries/google-code-prettify with prettify.js
and prettify.css inside it, along with any lang-*.js files you
decide to include.

You get a cookie for putting in this bit :D

> define('PRETTIFY_LIBRARY_FOLDER_NAME', 'google-code-prettify');

Is this ever going to change? Even if it did, how hard would it be for you, the module maintainer, to do a find and replace? Constants like this seem pointless to me.

> function prettify_filter_info() {

You're missing docblocks on nearly ALL your functions. Run the whole module through Coder review please!

Would love to see this as a full project!

Hello,

For the past year I have been working on a prettify module for Drupal 6, the module is similar to this but have additional features: out of the box, the module can automatically perform syntax highlighting of source code snippets without using input filter (it detects source code snippets on <pre> or <code> tags or using custom jQuery selectors). It also allows you to use an input filter. Currently, the module D6 version is used in production sites.

I have ported the module to Drupal 7 and I have released the full project Google Code Prettify module for Drupal.

You are welcome to join forces. Any ideas, contributions and suggestions are always welcome too!

It appears that there have been multiple project applications opened under your username:

Prettify: http://drupal.org/node/1235102
Menu Empty: http://drupal.org/node/1282270

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue.

With this in mind, I have marked your secondary applications as 'closed(duplicate)', and left one application open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one I that I have left open, then please feel free to close the 'open' application as a duplicate, and re-open one of the other project applications which I had closed.

Thanks in advance for your patience and understanding!