... using drush_MODULE_post_COMMAND().

CommentFileSizeAuthor
#19 1236238_17_arc2_auto_download.patch666 bytespenguino
#17 1236238_16_arc2_auto_download.patch822 bytespenguino
#14 1236238_13_arc2_auto_download.patch572 bytespenguino
#6 1236238_6_arc2_auto_download.patch4.68 KBscor
#5 1236238_5_arc2_auto_download.patch2.58 KBscor
#1 1236238_1_arc2_auto_download.patch2.18 KBscor

Comments

scor’s picture

scor commented
Status: Active » Needs review
StatusFileSize
new 1236238_1_arc2_auto_download.patch2.18 KB

this patch also refactor the download function to avoid re-downloading every time the library if it already exists.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

Good idea.

Why does this use the libraries path 'ARC2' when we use define('RDF_ARC2_PATH', libraries_get_path('arc'));?

scor’s picture

scor commented

I was looking at rdfx.module when writing this patch, and purposely used 'ARC2' because that's the name of the library. I think we should switch the name in rdfx.module too, even though this will break existing implementation of people using the libraries module (not sure how many, but I don't think there are tons).

Anonymous’s picture

Anonymous (not verified) commented

This patch should include the fix to use it in rdfx, then, shouldn't it? Because if drush downloaded it to ARC2, the module still wouldn't recognize it as being downloaded. Or am I missing something.

scor’s picture

scor commented
Status: Needs work » Needs review
StatusFileSize
new 1236238_5_arc2_auto_download.patch2.58 KB

absolutely!

I'm thinking we'll need an update function to notify those who used the libraries module. I'll include it shortly.

scor’s picture

scor commented
StatusFileSize
new 1236238_6_arc2_auto_download.patch4.68 KB

added update function

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

Well isn't that neat! Nice work.

Tested this on an installation that depends on RDFx for SPARQL Views. Worked like a charm, moving directory etc.

Committed with http://drupalcode.org/project/rdfx.git/commit/a7af80d

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dman’s picture

dman commented

FYI, wget: unrecognized option `--no-check-certificate' Failed on my OSX.
GNU Wget 1.9.1
Not important enough to re-open - unless someone knows a quick work-around

scor’s picture

scor commented
Status: Closed (fixed) » Active

the --no-check-certificate was there to avoid a warning during the download, but I believe github has fixed this now (at least I cannot reproduce this warning), so we could remove the --no-check-certificate option...

scor’s picture

scor commented
Assigned: scor » Unassigned
Issue tags: +Novice

tagging for novice

scor’s picture

scor commented
Issue tags: +RDF, +sprint

tagging

penguino’s picture

penguino commented
Assigned: Unassigned » penguino

patch pending.

penguino’s picture

penguino commented
Assigned: penguino » Unassigned
Status: Active » Needs review
StatusFileSize
new 1236238_13_arc2_auto_download.patch572 bytes

removed the --no-check-certificate option...

scor’s picture

scor commented
Status: Needs review » Needs work 
+++ b/drush/rdfx.drush.inc
@@ -88,7 +88,6 @@ function rdfx_drush_arc2_download() {
   elseif (drush_op('chdir', $path) &&
-      drush_shell_exec('wget --no-check-certificate -O arc.tar.gz http://github.com/semsol/arc2/tarball/master') &&
       drush_shell_exec('tar zxvf arc.tar.gz') &&

oops, that actually remove the entire line. you just need to remove the --no-check-certificate in the command, but keep the rest of the command

penguino’s picture

penguino commented
Assigned: Unassigned » penguino

working...

penguino’s picture

penguino commented
StatusFileSize
new 1236238_16_arc2_auto_download.patch822 bytes

removed just the "--no-check-certificate" parameter...

scor’s picture

scor commented 
+++ b/drush/rdfx.drush.inc
@@ -88,8 +88,8 @@ function rdfx_drush_arc2_download() {
-      drush_shell_exec('wget --no-check-certificate -O arc.tar.gz http://github.com/semsol/arc2/tarball/master') &&
-      drush_shell_exec('tar zxvf arc.tar.gz') &&
+    drush_shell_exec('wget -O arc.tar.gz http://github.com/semsol/arc2/tarball/master') && ¶
+ drush_shell_exec('tar zxvf arc.tar.gz') &&

indentation has broken and the first line as whitespace in the end.

penguino’s picture

penguino commented
Assigned: penguino » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 1236238_17_arc2_auto_download.patch666 bytes

removed just the "--no-check-certificate" parameter...(without over-editing)

mlncn’s picture

mlncn commented
Status: Needs review » Reviewed & tested by the community

Very nice, and a perfect byte size...

scor’s picture

scor commented
Status: Reviewed & tested by the community » Fixed

thanks for your patience John. Fixed with http://drupalcode.org/project/rdfx.git/commit/68a8376 and your name in the list of RDF Extensions committers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tasawar’s picture

tasawar commented

I am unable to locate ARC2 Library on right location. i have tried two ways 1. using DRUSH commend 2. using libraries Module in Drupal 7x. any one teach me how to install ARC2 Library in drupal 7x. i am working on rdfx module and its related modules.

scor’s picture

scor commented

@tasawar could you open a separate support request ticket to resolve your issue please with more details on what you tried, and perhaps with the error messages you got? http://drupal.org/node/add/project-issue/rdfx