hi folks (if anyone else happens to be reading this issue queue)...

i've just finished carefully reviewing the commits for the 5.x port that happened while i was away. mostly, it looks fine, with a few minor fixes. i also just spent a few hours digging through the bug queue, writing fixes, and committing them. there are a couple of critical bugs that still remain, but i don't have time to deal with those right now:

http://drupal.org/node/32728
http://drupal.org/node/99329

i'd like to make a 5.x-1.0 release in the near future, but i'd appreciate a little testing/feedback, to make sure my recent changes are all good, and there are no other show-stoppers. in particular, i'd appreciate it if anyone who uses the email functionality in this module could make sure all of that is still happy, since that's a) a little harder for me to test given my test environment and b) functionality i don't use or care much about...

anyway, any input on the quality of the end of the DRUPAL-5 branch in preparation for an official release would be most appreciated.

thanks,
-derek

Comments

add1sun’s picture

add1sun commented

It is working fine for me in my test environment. There is just one bug that I will create a separate issue for which is that if a user has view signups permissions but not view profiles, they shouldn't get a link to the user profiles when looking at the list of attendees.

The email confirmation worked, didn't test out the reminder email yet.

thanks for moving this forward.

add1sun’s picture

add1sun commented

Tested out the current 5 (signup.module,v 1.74.2.8 2007/03/09 19:57:14) and it works fine except the signup_forms() bug fix (http://drupal.org/node/125762) hasn't been applied to this branch yet.

HEAD works spanky on D5.

dww’s picture

dww
we/he/they
commented

thanks for the reminder, add1sun! ;) http://drupal.org/cvs?commit=60124

and, by "spanky", you mean except for the known bugs and tasks:

http://drupal.org/project/issues/signup?states=1,8,13,14,15,4&categories...

right? ;) a few of those are in "needs review" status, if you're so inclined.

that said, i'm thinking we're not going to solve *all* of the known bugs before an official 5.x-1.0 release. many of these have been broken forever, and people still seem to get along with this module (e.g. i don't use any of the email notification stuff, so i don't care about those bugs). so, i'm leaning towards an official release as soon as the last few patches i've already done are in, and then plan on releasing a 5.x-1.1 once we've fixed a few of the other big bugs.

cheers,
-derek

dww’s picture

dww
we/he/they
commented
Status: Active » Postponed

i want to cleanup the permissions before i ship the official 5.x-1.0 release:
http://drupal.org/node/69283
http://drupal.org/node/69367
http://drupal.org/node/126632

dww’s picture

dww
we/he/they
commented

update: this is now only blocked on:
- http://drupal.org/node/126942
- a little more testing of the DRUPAL-5 branch in the wake of my recent round of commits

i'm not going to block the official release on http://drupal.org/node/121675 -- it's a new feature, and not a critical change, so it can wait for 5.x-1.1 or perhaps 5.x-2.0 (once i start adding a bunch of new features).

dww’s picture

dww
we/he/they
commented

update -- currently blocked on:
http://drupal.org/node/128287
http://drupal.org/node/128300
(both are pretty small and should be easy)...
almost there. ;)

dww’s picture

dww
we/he/they
commented

even though no one reviewed those other patches, i just committed them, anyway. so, we're *almost* there. i just have 1 more patch i'm working on, to finally clean up the code (just re-formatting for coding standards and indentation/whitespace stuff). as soon as that goes in (probably tomorrow), i'll mark this "needs review", so i can hopefully get a few folks to act as beta testers before i make the official release...

dww’s picture

dww
we/he/they
commented
Priority: Normal » Critical
Status: Postponed » Needs review

ok, i've committed everything i plan to commit before the 5.x-1.0 release. at greggle's request, i created a 5.x-1.x-dev snapshot release node:

http://drupal.org/node/129623

please test that (or the end of the DRUPAL-5 branch from CVS) and comment here with the results. in particular, i'd love to hear about how the email notification stuff is (or isn't) working. of course, if you find that some of the known bugs are still around, just comment in those issues, not in here (i'll see when they get bumped). thanks!

mdowsett’s picture

mdowsett commented
Category: task » feature
Priority: Critical » Normal

I am excited to see that a v5 release is coming. I have an events management website still on v4.5 and am dying to get it onto v5. I was using the eventfinder.module in 4.5 and that has been discontinued long ago so have to depend on the signup.module for my needs now.

In my opinion all the settings for the signup module (found at /admin/settings/signup) should be event specific rather than site wide. All my events have different owners that will have different confirmation confirmation and reminder emails to send out. Can that stuff be put in the signups section of the node (event) creation?

A few other features that I loved in the eventfinder module that I'd love to see in the signup module:
- ability to set a maximum number of signups per event
- ability for event owner to

And I am assuming that thru CCK you'll be able to add fields to the event node and with Views you'll be able to customize registrant lists???

Thanks for all your help...I am dying for this to work!

dww’s picture

dww
we/he/they
commented
Category: feature » task
Priority: Normal » Critical

@mdowset:
- the 5.x-1.0 version is in a "feature freeze" at this point, i'm just soliciting testing and reviews of the current functionality in preparation for a new stable release.
- i'll add new features in the 5.x-2.* series, but that's blocked on getting 5.x-1.0 out the door
- please don't add random feature requests at the end of existing issues. please search first (since many features have already been proposed and discussed at length), and if your feature isn't already in the queue, submit a separate request for each feature.
- "seat limits" have been discussed (at length) before: http://drupal.org/node/32482
- the other feature you mentioned was cut off. previewing a post before submitting is always a good idea. ;)
- this issue (#123689) is about the critical task of getting the 5.x-1.0 release done, since that's what's blocking all other progress in this module at the moment.

thanks,
-derek

add1sun’s picture

add1sun commented

Ok, I've done a bit of testing so far and it haven't found any gotchas but I still would like to get this onto another test environment and run the email bits through their paces. I'm going to try *really* hard to do this tonight. :)

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

http://drupal.org/node/133563

yay! ;) thanks to everyone who helped test and make this release as good as it is.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)