Hello

I've installed the HEAD version of the signup module while running Drupal 5.1

It lets me add signups and I can see a list of who has signed up, but I am getting the following two error messages.

1. When someone does signup for something, after they press submit they get:

* warning: mail() [function.mail]: Failed to connect to mailserver at "localhost" port 25, verify your "SMTP" and "smtp_port" setting in php.ini or use ini_set() in C:\www\drupal\includes\common.inc on line 1970.
* warning: mail() [function.mail]: Failed to connect to mailserver at "localhost" port 25, verify your "SMTP" and "smtp_port" setting in php.ini or use ini_set() in C:\www\drupal\includes\common.inc on line 1970.

(it always shows up twice) and no confirmation emails are sent.

2. Whenever I as admin try to edit an event I get:

: Object of class stdClass could not be converted to string in C:\www\drupal\modules\signup\signup.module on line 957.

I did a search but couldn't find anything on this issue - is it something I'm likely to be able to sort out, or should I wait for the official 5.x release?

Thanks in advence for your help

Tom

Comments

add1sun’s picture

Well, issue number one has to do with your mailserver setup and isn't specific to signup. I can however replicate issue number 2. I get the same error. Tried it on an event content type as well as a non-event. The error doesn't seem to affect the function at all since you can still edit, change dates, change signup settings, etc and it isn't effected by signups open/closed.

Using D5.1 and the latest HEAD signup (signup.module,v 1.79 2007/03/03 07:14:57)

dww’s picture

Title: 2 Error Messages while running HEAD in 5.1 » php5 error in signup_forms()
Assigned: Unassigned » dww
Category: support » bug
Status: Active » Needs review
StatusFileSize
new694 bytes

re: #1 -- yeah, your site just isn't configured for email. search elsewhere for help with that.
re: #2 -- please try this patch. php5 is more picky than php4 about such things. ;)

add1sun’s picture

nope, still getting the error with the patch on PHP 5.2.0. :( At least you're right that it is a PHP 5 error, since 4.3.11 worked no problem.

dww’s picture

Title: php5 error in signup_forms() » serious flaw in signup_forms()
StatusFileSize
new1.37 KB

actually, after doing some debugging, reading the docs, and getting some wisdom from eaton, i now realize that the existing signup_forms() implementation is very broken. we should only be doing this re-mapping magic if we see a signup_user_cancel_form. attached patch should fix the problems, and then resolve the php5 warning. needs heavy testing, especially the "signups" tab on a signup-enabled node, since it's screwing with some deep FAPI plumbing.

add1sun’s picture

Yessir, that patch does the trick. Hammered the signups tab pretty well on a number of nodes, turning things off and on and cancelling, etc. Worked fine on both PHP 4 and 5.

dww’s picture

Component: Miscellaneous » Code
Status: Needs review » Fixed

committed to HEAD. thanks for the help testing!

Tom_Mason’s picture

Fantastic, works perfectly now. Thanks for your help.

Tom

dww’s picture

"backported" (really, same patch committed) to DRUPAL-5 branch, too. thanks to add1sun for reminding me. ;)

Anonymous’s picture

Status: Fixed » Closed (fixed)