Closed (fixed)
Project:
Revisioning
Version:
7.x-1.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
5 Aug 2011 at 11:10 UTC
Updated:
1 Jan 2012 at 18:00 UTC
Jump to comment: Most recent file
When adding a condition in Rules, the options provided by Revisioning are stuck out on their own and do not work correctly when trying to specify a type of revision.
The patch attached adapts Rules' handling of node content type selection.
There is also a wrapping function to prevent passing a parameter to revisioning_revision_states() that it can't handle.
Comments
Comment #1
lazysoundsystem commentedRevised patch to handle changes in
revisioning_condition_revision_is().Comment #2
rdeboerThanks so much for the patch!
Will check in soon.
Rik
Comment #3
rdeboerCommitted to master branch. Will be in 7.x-1.3 release.
Thanks again, lazysoundsystem!
Rik
Comment #4
jp.stacey commentedThis patch doesn't work with drush make: alternative without git prefixes attached.
Comment #5
rdeboerThanks jp,
For those not familiar with patches, just check out the master branch, as the patch has been committed to Git.
Rik
Comment #6
lazysoundsystem commentedThanks for committing that, Rik.
Not quite worth its own issue and patch, there is another related change for
revisioning_rules_action_info()where:should be:
to make the actions show up in the right place in the dropdown.
Thanks again.
Comment #7
lazysoundsystem commentedAnd while we're at it...
This, from
revisioning_rules_event_info():needs changing to:
Comment #8
lazysoundsystem commentedOne last thing...
Checking the condition in
revisioning_condition_revision_is()gives errors if the revision info isn't already set.This patch includes a call to
revisioning_set_node_revision_info()and the two changes from 'module' to 'group' from the last two comments.(Just to be clear, as the earlier patch is already committed, those changes are not repeated in this patch.)
Comment #9
lazysoundsystem commentedAnd with apologies for the noise, here's a single patch with all the above changes included, made against branch 7.x-1.2.
Comment #11
rdeboerHave not committed patches since #3, yet
Comment #12
rdeboerChecked in. Sorry for the delay.
See http://drupal.org/node/407994/committers.