Other module should be able to alter the RDF model while it's getting built, for example to add more triples if the generic entity API based algorithm does not support some required triples.

CommentFileSizeAuthor
#10 1240778_10_rdfx_alter.patch954 bytesscor
#8 1240778_8_rdfx_alter.patch657 bytesscor
#1 1240778_1_rdfx_alter.patch559 bytesscor

Comments

scor’s picture

scor commented
Status: Active » Needs review
StatusFileSize
new 1240778_1_rdfx_alter.patch559 bytes

This patch assumes #1237078: Align rdfx_get_rdf_model() prototype with entity API naming convention.

bkudrle’s picture

bkudrle commented

Patch was applied successfully in the Quickstart environment and passed all of the RDF and RDFx simpletests. I plan on doing some tests with other modules as well.

scor’s picture

scor commented
Issue tags: +RDF, +sprint

tagging

Anonymous’s picture

Anonymous (not verified) commented

Using drupal_alter at this point will result in a further divergence between RDFa and other serializations of the same resource, and one which doesn't come from the differences in syntax itself.

I don't have an issue in particular with this, but it will rile the pedants.

scor’s picture

scor commented

True. One the other hand, wouldn't it help to add to the RDF model the bits which are only present in RDFa? There might be cases though where some data does not make sense to appear in the HTML because it's too verbose or naturally doesn't appear in HTML (I agree it could be added with hidden metadata elements though). Danbri also made the argument that there is no rule, and that "there are all kinds of reasons why human-facing HTML pages vs feed-style RDF/XML links would be organized differently".

Let's try to find a compromise here. I think that at least anything that appears in RDFa should also appear in the RDF model (and thus any serialization + SPARQL Endpoint).

Anonymous’s picture

Anonymous (not verified) commented

Dan Bri also says:

on the other hand, having things diverge without reason can also confuse

It should at least be very clearly documented that this shouldn't be used as a hack workaround and that people should register their predicates with the core Mapping API to the greatest degree possible.

scor’s picture

scor commented
Assigned: Unassigned » scor
Status: Needs review » Needs work

I agree, this needs to be documented. I'll take care of that.

scor’s picture

scor commented
Status: Needs work » Needs review
StatusFileSize
new 1240778_8_rdfx_alter.patch657 bytes

here is an updated patch with a warning on diverging RDF data. Does that address your concerns, Lin?

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

I don't believe it's strong enough, and it is difficult to parse.

I would say:

Allow other modules to alter the RDF data model before serialization. For example, a module could add elements which are not supported by the Entity API.

This should only be used in special cases. The data is not added to Drupal's internal model, and is thus not accessible to other modules or during Drupal's normal rendering stream. It will only show up in non-RDFa serializations of the entity.

scor’s picture

scor commented
Status: Needs work » Needs review
StatusFileSize
new 1240778_10_rdfx_alter.patch954 bytes

Thanks Lin, incorporated your suggestion. Also split the index attachment and CURIEs expansion so the drupal_alter() happens in between the two.

ashepherd’s picture

ashepherd commented

I'm wondering if the $id the drupal_alter() line was meant to refer to the entity id, the $wrapper->getIdentifier()

drupal_alter('rdf_model', $res, $type, $id);
to
drupal_alter('rdf_model', $res, $type, $wrapper->getIdentifier());

my apologies, I was working off of "7.x-2.0-alpha4"

ashepherd’s picture

ashepherd commented
Issue summary: View changes

fix typo

scor’s picture

scor commented

Not sure I understand your question. yes, $id is the entity ID passed to the rdfx_get_rdf_model(). It might be the same as $wrapper->getIdentifier().

scor’s picture

scor commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I've been using this patch on a few projects and it's working well. I'm planning to commit this in 2 weeks.

scor’s picture

scor commented
Status: Reviewed & tested by the community » Fixed

Fixed with http://drupalcode.org/project/rdfx.git/commit/cc7d4fc

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.