Currently the README.txt file, when delineating the ways to install the ARC2 library, says that it should be put into the sites/all/modules/rdfx/vendor/arc/ARC2.php structure if drush is not used. However, from my understanding the preferred location of this library is now in the sites/libraries directory, along with the libraries module being loaded. This would make it also consistent with the path used in the Reports >> Status Reports for the ARC2 library. The README.txt file should reflect this new approach.

CommentFileSizeAuthor
#10 readme-1241708-10.patch1.01 KBclayball
#8 readme-1241708-8.patch1.01 KBclayball
#6 rdf-download.jpg33.2 KBmattkoltermann

Comments

clayball’s picture

clayball commented
Assigned: Unassigned » clayball

Good point. I'll update this this week.

laura s’s picture

laura s commented

I ran into this as well (because the drush script did not work for me).

scor’s picture

scor commented

I'm in favor of the libraries location as well, +1.

@Laura s, I'm interested to hear about the issue you had with the drush script. Would appreciate if you could paste the error you got (feel free to create a separate issue for that).

laura s’s picture

laura s commented

Dang! I thought I would have pasted the drush error. Now I am working remote on a different machine, so I don't have the backscroll to review. Drush did not install the library, but I don't recall what the error was. When I return, I will see if I can dredge it up.

clayball’s picture

clayball commented

Sorry.. been busy. Will update this week.

mattkoltermann’s picture

mattkoltermann commented
StatusFileSize
new rdf-download.jpg33.2 KB

FYI: I ran into the attached error until I did "sudo drush rdf-download" -- now all is well.

scor’s picture

scor commented

FYI: I ran into the attached error until I did "sudo drush rdf-download" -- now all is well.

hum, that seems like a file permission specific issue. Feel free to open a new issue about this if you feel there is a bug in the drush command of this module.

clayball’s picture

clayball commented
Status: Active » Needs review
StatusFileSize
new readme-1241708-8.patch1.01 KB

Sorry for the long delay. Here's a patch.

scor’s picture

scor commented
Version: 7.x-2.0-alpha3 » 7.x-2.x-dev
Status: Needs review » Needs work 
+++ b/README.txt
@@ -44,11 +44,12 @@ Download the following modules to avail more RDF features:
+         http://github.com/semsol/arc2/tarball/master and extract it in the ¶
+         libraries directory such that you end up with the following file ¶

dreditor points out some whitespaces at the end of these lines.

side question: what do other modules do about the dependency on the libraries module? it seems for example the wysiwyg module does not require libraries. maybe rdfx should also check the sites/all/libraries/arc location without requiring libraries? anyways, let's keep rolling this README fix in the meantime...

clayball’s picture

clayball commented
StatusFileSize
new readme-1241708-10.patch1.01 KB

Thanks, scor. Fixed whitespace.

Good question regarding the libraries module. IMHO, I think making it required and having only one location would keep things simple. Allowing multiple locations seems reasonable but also complicates things which I don't think is really necessary and could possibly add confusion.

clayball’s picture

clayball commented
Status: Needs work » Needs review

Changing status to 'needs review'.

scor’s picture

scor commented
Status: Needs review » Fixed

Thanks Clay! fixed with http://drupalcode.org/project/rdfx.git/commit/c492a4d

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.