Constants used in test are of the form G2FOO, whereas they are defined as define('G2\FOO').

They should be fixed and use namespace constants instead of define() anyway.

CommentFileSizeAuthor
#1 g2_constants-1242520-1.patch54.1 KBfgm

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs review
StatusFileSize
new g2_constants-1242520-1.patch54.1 KB

This patch converts all constants to namespace.

Regrettably some constants had to be inlined because define() supports function calls for initializers but const does not.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Fixed

Committed to 7.x since all tests pass.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.