Here's some Drupal style cleanup. The only major thing is that callback args should be an array.

CommentFileSizeAuthor
sso.patch2.04 KBRobRoy

Comments

wayland76’s picture

wayland76 commented

Why has the user access check been removed?

wayland76’s picture

wayland76 commented

...and, is this related to this change:

http://drupal.org/node/126299

wayland76’s picture

wayland76 commented

Well, I've applied the patch, but retained the user access check. The fix is in HEAD, and should appear within the next 24 hours.

wayland76’s picture

wayland76 commented
Status: Needs review » Postponed (maintainer needs more info)

Needs more info

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Postponed (maintainer needs more info) » Fixed

I guess, because the access check is already performed in the menu. singlesignon_admin_settings() would need to be directly invoked via drupal_get_form() to get the contents of this form (without an access check), which probably doesn't happen. Thus, marking as fixed. Thanks, RobRoy!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.