The new support for an alternative timepicker is great, but the documentation as to what timepicker was chosen and how to get it is a little sparse right now unless you read the issue queue.

This is a particular problem since it seems that 'Use dropdown timepicker' is now the default selection for date popup.

CommentFileSizeAuthor
#3 date-popup.png56.78 KBmatt b

Comments

karens’s picture

Category: bug » task

It is the default only if it exists. If it exists apparently you figured out how to download it. If it doesn't exist there are instructions about how to download it (with a link) on the configuration screen where you have an option to choose it.

But I agree we should probably add information about the timepicker options and where to download it to README.txt in the Date Popup module. Patches welcome.

jastraat’s picture

Strangely it does exist, and I haven't downloaded any additional libraries related to timepicker.

matt b’s picture

StatusFileSize
new56.78 KB

Me too - I upgraded to 7.x-2.x-dev 13th Aug from 7.x-2.x-dev 24th April, but did not install any additional libraries, and 'Use dropdown timepicker' had been set (presumably by the upgrade process). On the prior dev version 'Use default JQuery timepicker' was set. Additionally I cannot see any links on how to download and install the additional libraries. I switched to 'Use default JQuery timepicker' and the warnings regardings "sites/all/libraries/wvega-timepicker/jquery.timepicker.js" have stopped.

karens’s picture

Found the bug I think you were seeing. It only appears if you have the libraries module enabled. It turns out that the libraries_get_path() function does no testing to be sure the path is valid before returning it. The code was then trying to use the invalid path returned by that function. I added an 'if_exists' to that process.

It still would be good to get some documentation added to the README.txt file.

matt b’s picture

that makes sense - I have the libraries module installed, but do not have any timepicker libraries installed.

karens’s picture

Status: Active » Fixed

I added this information to the README.txt file in the Date Popup module.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.