The "Edit metatags" permission isn't named correctly. Users without this permission can still edit content metatags, they just can't edit path-based metatags.

Please rename this permission to "Edit path-based metatags".

CommentFileSizeAuthor
#1 metatags_quick-edit-permission-1247310-2.patch735 bytesAndrew Schulman

Comments

Andrew Schulman’s picture

Andrew Schulman commented
Title: "Edit metatags" permission should be "Edit path-based metatags" » "Edit meta tags" permission doesn't restrict editing bundle/entity tags
StatusFileSize
new metatags_quick-edit-permission-1247310-2.patch735 bytes

Instead of renaming this permission, why not fix the module instead so that it applies to editing bundle/entity meta tags as well. The attached patch does this. Users without the "Edit meta tags" permission won't be able to view or edit the meta tags in node/user/etc. editing forms.

Andrew Schulman’s picture

Andrew Schulman commented
Status: Active » Needs review
valthebald’s picture

valthebald
Location Sofia
commented

I think it's more consistent to implement hook_field_access, as patch at #2 suggests.
Any other opinion? (I will let several days for possible objections, then commit the patch).
Thanks!

valthebald’s picture

valthebald
Location Sofia
commented
Status: Needs review » Fixed

committed to 7.x-2.x after getting on objections

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.