A Feeds parser for image bookmarking service FFFFOUND!

More details in my sandbox.

I'm using the module on my own site.
My FFFFOUND! profile
FFFFOUND! RSS feed

CommentFileSizeAuthor
#1 feeds_ffffound-1247886-1.patch17.55 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Needs work
StatusFileSize
new feeds_ffffound-1247886-1.patch17.55 KB

This was remarkably well written, major props. Every critique I have is cosmetic coding standards.

Remove the LICENSE.txt, it will be automatically added by the packaging script
Be careful about trailing whitespace
No quotes around name/description in .info
One of the @param doxygen blocks had the order of type and name swapped

Here's a patch.

persand’s picture

persand commented

Thanks Tim!
The patch has now been applied and committed: http://drupalcode.org/sandbox/per/1247856.git/commit/8ffa9bf

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Fixed

By far the best ratio of "complicated module vs ease of review". Major props.

I've granted you full project creation rights. Use this ability carefully!


persand’s picture

persand commented

Thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.