The patch for this includes the patch in #1249982: User list not being updated properly, so you only need to apply this one once reviewed. Otherwise I'll re-roll the patch if necessary.
Right now autocomplete is done with the TAB key, which didn't work with Chromium (on Linux) in my tests, but I made it easy to add an additional keycode. I didn't come up with one that works in Chromium yet, maybe someone else has an idea?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | tab-autocomplete.patch | 4.47 KB | a.ross |
| #2 | tab-autocomplete.patch | 4.42 KB | a.ross |
| tab-autocomplete.patch | 4.4 KB | a.ross |
Comments
Comment #1
a.ross commentedComment #2
a.ross commentedArgh why do I keep doing that... autocomplete could give "false positive" with that patch, here is a fixed one.
Comment #3
a.ross commentedAlright seems the keyPress event is not fired for the TAB key in some browsers, but the keyDown event is. I have updated the patch to reflect this fact, so it now works with IE and chromium and others.
It should be noted, however, that in the case of IE, it's not possible to find the keyboard cursor position, so I assume that the cursor is at the end. I honestly don't feel like writing an ugly workaround for this one, maybe someone else can do it. The line to do this just for damned IE is ugly enough as it is.
Comment #4
a.ross commentedAny news on this?
Comment #5
a.ross commentedI'd like to reroll this patch (against 7.x-2.x or GSoC?). I did but I can't test if it works or not, since in that branch user list is not updated at all. I will use this feature in production so it would be nice if someone could have a look at it.