Context block reaction lists blocks without calling hook_block_info_alter(). [#1251240]

Comment	File	Size	Author
#6	0001-Issue-1251240-Use-block-cache-setting-from-DB_d6.patch	1.43 KB	fabianx
#5	0001-Issue-1251240-Use-block-cache-setting-from-DB.patch	1.42 KB	fabianx
#2	context.1251240-2-hook_block_info_alter.patch	3.08 KB	adamdicarlo
#1	context_hook_block_info_alter-1251240-1.patch	2.65 KB	dalin

Comment #1

dalin

he/him

English

🇨🇦, 🇲🇽, 🌍

commented 16 August 2011 at 19:49

Status:

Active

» Needs review

Status	File	Size
new	context_hook_block_info_alter-1251240-1.patch	2.65 KB

Since this hook will only be implemented if Block module is enabled, then we can let Block module do the heavy lifting.

Log in or register to post comments

Comment #2

adamdicarlo commented 3 October 2011 at 21:49

Status	File	Size
new	context.1251240-2-hook_block_info_alter.patch	3.08 KB

This isn't specific to Blockcache Alter -- I just ran into this bug when using hook_block_info_alter() to remove blocks from a certain module -- and found they were still on Context's block list.

This patch fixes the problem for me. Here it is rerolled to be compatible with Drush Make, and giving attribution to @dalin.

Only questionable part of the patch is that if the block module is disabled, hook_block_info_alter() still isn't called. Should it be?

Log in or register to post comments

Comment #3

adamdicarlo commented 3 October 2011 at 21:52

Title:

Context loads blocks in a manner that never calls hook_block_info_alter() which breaks Blockcache Alter module.

» Context block reaction lists blocks without calling hook_block_info_alter().

Hopefully clarifying title.

Log in or register to post comments

Comment #4

dalin

he/him

English

🇨🇦, 🇲🇽, 🌍

commented 4 October 2011 at 20:50

"Only questionable part of the patch is that if the block module is disabled, hook_block_info_alter() still isn't called. Should it be?"

I thought about that too, but if we ignore Context module for a moment, if Block module is not enabled the hook doesn't get called either. Otherwise we have to duplicate _block_rehash() which would not be fun.

Log in or register to post comments

Comment #5

fabianx commented 20 April 2012 at 01:06

Status	File	Size
new	0001-Issue-1251240-Use-block-cache-setting-from-DB.patch	1.42 KB

For fixing the blockcache_alter problem:

Here is another patch, which is much simpler and works for D6 and D7 the same.

The only thing it does is retrieve the cache value also from the database, but that works for blockcache_alter in all circumstances.

This is obviously much simpler and does not fix the other problems context has with blocks, but it fixes blockcache_alter and that was what I needed.

Log in or register to post comments

Comment #6

fabianx commented 20 April 2012 at 01:09

Status	File	Size
new	0001-Issue-1251240-Use-block-cache-setting-from-DB_d6.patch	1.43 KB

And the D6 version for fixing blockcache_alter with context:

Same approach as D7 version.

Log in or register to post comments

Comment #7

fabianx commented 20 April 2012 at 01:13

Issue tags:

+Performance

Add Performance tag, because with blockcache_alter sites can be much much faster and context is preventing this without this patch.

Log in or register to post comments

Comment #8

bastnic commented 21 May 2012 at 22:31

I must agree with Fabianx. I updated the context_blockcache_alter with his patch and with it everything work without patching anything. But it will be easier to include it directly into context.

Log in or register to post comments

Comment #9

bastnic commented 14 June 2012 at 18:59

Status:

Needs review

» Reviewed & tested by the community

As I said before, the patch in #5 works perfectly in the context_blockcache_alter, which is used on a number of websites in production.

It gives a real performance boost for almost all website where it's installed, so I set it to reviewed and tested by the community.

Log in or register to post comments

Comment #10

tekante commented 30 June 2012 at 16:11

Status:

Reviewed & tested by the community

» Fixed

Patch from #2 applied after confirming that it indeed allowed for a hook_block_info_alter to be honored by context. I believe this removes the need for #7 but if not please reopen.

Should be available in the next dev build.
http://drupalcode.org/project/context.git/commit/92d0c33bbe931e99b89f313...