Closed (fixed)
Project:
Date
Version:
7.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Aug 2011 at 05:26 UTC
Updated:
3 Sep 2011 at 13:31 UTC
Steps to reproduce:
The attached patch fixes the bug, though with a todo explaining why it's not a perfect fix. However, this fixes the bug for by far the most common situation in which it will occur (with the Long, Short, and Medium date types provided by Drupal core).
I've also included some test changes which will fail without the main part of the patch but pass with it.
| Comment | File | Size | Author |
|---|---|---|---|
| date-format-type-fix.patch | 5.39 KB | David_Rothstein |
Comments
Comment #1
karens commentedOK, I see the issue here. The problem is if people haven't already configured date and time, since we really need them to do that first. Maybe we need to add a system requirements check, or just a warning when the date module is first enabled to trigger them to go set those values.
In the meantime, this is probably as good as we can do.
Comment #2
karens commentedOK, I added both an installation message and a system requirements test that the timezone, first day of week, and date formats have been configured. If they are configured, the status report tells you what they are set to with links to where you reset them. I think that will all be helpful. Next I can go ahead with this patch, which hopefully will finish adding a layer of protection for sites that haven't set these things up.
Comment #3
karens commentedCommitted. Thanks!