Remove checkbox spacing

Patch looks good. RTBC.

I want to fix it a long time ago but tables in Drupal are without fixed-width, was though it is drupal style.

14px is the best value for IE I think. but in Firefox is 16px.

(Of course you won't see the diffident because browsers omitted it when width is smaller than content)

I recheck it again, the actually width of checkbox in IE is 13px. I don't know if any browsers checkbox smaller than this value. A CSS trick is set the width to "1px" that let the browsers calculating the right value (min width) for it.

re-roll patch + #4

+/*
+ * Checkbox have different width size in cross-browsers. Set width to a minimum
+ * value that trigger browsers to automatically size minimum width of TH element.
+ */

The first line should be:

/**

" Checkbox have different width size in cross-browsers." reads oddly to me, maybe "Checkboxes have different widths in different browsers"?

I'm not sure I understand the documentation. Is the minimum with a hack or a well-documented feature that works across all browsers?

Furthermore, the help text has a couple of grammar issues:

1. 'Checkboxes have' instead of 'Checkbox have'.

2. 'that triggers' instead of 'that trigger'.

Could this be backported to D7?

How about:

Reducing "select all" column's width.
Due to form elements rendering difference in across browsers and operating systems, it cannot specify a fixed width on TH element. So we reduce the widths to a minimum value that will trigger browser engines to calculate the best TH element width.

1 pixel isn't a magic value. browsers expand table's column to fit the content. checkout how table width algorithms works: http://www.w3.org/TR/CSS2/tables.html#width-layout

@joachim,

It's theme changes, i bet it won't backport :(

or shorten it to:

Browsers will calculate the best width of TH element.

tagging Novice for Doc guy and native speakers. :)

Perhaps this wording documents the change better?

+/**
+ * Force browsers to calculate the width of a 'select all' TH element.
+ */

The comment in #15 is much clearer.

Makes sense. Committed/pushed to 8.x.

This was asked before back in #11, but was left unanswered. Can/should this be backported to D7?

+1 for backporting this to D7.

The content listing page (admin/content) looks good but people listing page (admin/people) has excess of width.

Have rerolled the patch #15 for d7.

can you add back the comments.

Rerolled with comment.

Looks good. RTBC.

Has anyone tested this in different browsers? Especially older versions of IE?

It seems relatively safe for backport... especially if it only affects Seven. (However, at least for Drupal 8 I actually can't really figure out why this was done in the Seven theme only. Doesn't the same issue exist for any theme?)

Tested on IE8 - everything works as should.

Tried adding patch to simplytest.me got message: "An error occurred while patching the project." Looks like this needs a re-roll.

24: 1252206_remove_checkbox_spacing_24.patch queued for re-testing.

Looks good! I applied this patch and it solves the issue! It looks a lot better now. Thank you!

Oh. I have no permission to update this issue, why ??

Anyone could marked it as "Reviewed & tested by the community" ?

I can't either! No idea why

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/67ad400

By the way, I'm still not sure why this fix is only in the Seven theme, but I guess it's up to some other issue to expand it beyond Seven if necessary.

Thanks for the additional testing (with IE8, etc) in the meantime.