[D6] Privatemsg Templates

I looked through your module, here is a patch with a couple coding standards fixes, see drupal.org/coding-standards and the patch itself, and please ask questions if you have any.

Remember to look over http://drupal.org/node/52287 for commit message conventions. For example, one for this patch could be Issue #1252548 by tim.plunkett: Coding standards fixes.

Once you've made these changes, set back to needs review and I will try to find time to install/test it.

Sorry, forgot to change status.

subscribe

* Git release branch missing, see http://drupal.org/node/1015226
* Don't use "/** .. */" style comments in function bodies, use "//" instead

Otherwise looks good. Now before I mark your application as RTBC, would you be so kind and do a review of one of the other project applications as well? We have currently quite a backlog and need every help we can get. Just pick one from this list and notify me here if you have done so: http://drupal.org/project/issues/projectapplications?status=8

Anyway, I don't want to hold this back.

Looking good in general:

82 $result = db_query("SELECT n.nid, n.title FROM {node} n WHERE n.type = '%s'", $type);

That should be wrapped in db_rewrite_sql or use node_access.

Review of the 6.x-1.x branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/privatemsg_templates.module:
   +20: [normal] Menu item titles and descriptions should NOT be enclosed within t().
   +21: [normal] Menu item titles and descriptions should NOT be enclosed within t().
   +77: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
  
  Status Messages:
   Coder found 1 projects, 3 files, 3 normal warnings, 0 warnings were flagged to be ignored
  

• Lines in README.txt should not exceed 80 characters, see the guidelines for in-project documentation.

This automated report was generated with PAReview.sh, your friendly project application review script. Please report any bugs to klausi.

But that are just minor issues, otherwise RTBC for me.

Thanks for your contribution, dineshcooper! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.

No, this is done by the menu system. See the documentation of hook_menu.

I am giving credits to the users who participated in this issue and the duplicate issues.