Description

This Drupal 7 theme is developed by Creative Development for their Drupal distribution including a connector module for "LiteCommerce" 3 e-commerce solution.

Features:
- Clean and smooth design
- Supports "lc_connector" module, styles module's pages and blocks correctly
- Built-in drop-down menu
- Sign-in form in a popup layer
- Optional Facebook and Twitter links in the footer
- 3 columns tableless layout (there are a few places where tables left for compatibility with older browsers)
- compatible with IE6+, FF3.5+ and Chrome 10+

More details are provided in the README.txt file

Screenshot attached. You can also see this theme in action at www.litecommerce.com (this site is powered by Drupal + LiteCommerce)

A link to the project page

http://drupal.org/sandbox/litecommerce/1236686

A direct link to git repository

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/litecommerce/1236686.git lc3_clean

Drupal version

Drupal 7

CommentFileSizeAuthor
lc3_clean_screenshot.png766.32 KBlitecommerce
README.txt2.06 KBlitecommerce

Comments

litecommerce’s picture

litecommerce commented
Priority: Normal » Major
litecommerce’s picture

litecommerce commented
Priority: Major » Critical
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Priority: Critical » Normal
Status: Needs review » Needs work
  • lines in README.txt should not exceed 80 characters
  • code style: indentation should be 2 spaces per level. Run coder to check style errors http://drupal.org/project/coder
  • Comments should start capitalized and end with a "."
  • @param doc block descriptions should be on a new line, see http://drupal.org/node/1354#functions
  • "@return void" don't document that, unnecessary
  • "Module manifest" - this is a theme, right?
litecommerce’s picture

litecommerce commented
Assigned: Unassigned » litecommerce
Status: Needs work » Needs review

klausi, thank you for the review and feedback!

I've fixed all the issues you listed: http://drupalcode.org/sandbox/litecommerce/1236686.git/commitdiff/8c0267...

The Coder module does not find any errors and warnings now excepting the following:
- A lot of warnings in lc3_clean.info. But this is rather Coder's issue because this file should not be interpreted as PHP script; similar warnings displayed when checking any standard Drupal themes' *.info files.
- Warning on alerting a text without t() wrapper in lc3_clean/js/jquery.blockUI.js. But this text is a service message which user will never see and I think we should not modify this 3rd-party script to fix the tiny issue

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
  • "variable_set('default_nodes_main', 1);": what do you need this variable for? you can use a default value in variable_get() anyway, so no need to set it beforehand.
  • @author, @copyright: Remomve that lines, drupal.org packaging adds a license file automatically. And you can leave credits/author details in README.txt
  • "Implementations hook_theme()." should be "Implements hook_theme().". And you copied the default hook documentation which is not useful here. Remove it.
  • ie.css: "#logo {" indentation errors for the body, always use 2 spaces.
  • jquery.blockUI.js: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.
litecommerce’s picture

litecommerce commented
Status: Needs work » Needs review

jquery.blockUI.js file has been removed from the theme:
http://drupalcode.org/sandbox/litecommerce/1236686.git/commitdiff/f06c7a...

and this commit for the rest notes:
http://drupalcode.org/sandbox/litecommerce/1236686.git/commitdiff/5d1cf5...

Thank you!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

layout.css: indentation errors, always use 2 spaces.

Otherwise this looks RTBC to me.

litecommerce’s picture

litecommerce commented

> layout.css: indentation errors, always use 2 spaces.
Fixed: http://drupalcode.org/sandbox/litecommerce/1236686.git/commitdiff/093958...

klausi, thank you very much for your work!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Fixed

Please take a moment to make your project page follow tips for a great project page.

Thanks for your contribution, litecommerce! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in minde: Commit messages - providing history and credit and Release naming conventions.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

summit’s picture

summit commented

Hi, I do not see the projectpage anywhere and the sandbox page gives a 404!
Greetings, Martijn