(Feel free to correct me if I'm wrong) -- Calls to chatroom_get_utc_timestamp() can just be replaced with a call to time() instead. I would attach a patch, but ... whoever has access can probably just do a quick grep/replace/commit. :)

I have removed the call to this function from the node.js module's drupalconlondon branch (also, correct me if I'm wrong here).

CommentFileSizeAuthor
#2 1263590-use-php-time.patch1.62 KBjzacsh
#1 1263590-use-php-time.patch4.22 KBjzacsh

Comments

jzacsh’s picture

jzacsh commented
Status: Needs work » Needs review
StatusFileSize
new 1263590-use-php-time.patch4.22 KB

Actually, i already had the drupalconlondon branch for this module opened anyway, so here's the patch to remove calls to the function.

jzacsh’s picture

jzacsh commented
StatusFileSize
new 1263590-use-php-time.patch1.62 KB

Wh00ps that was an aggregate format-patch output from `git`. Here's the patch for just this issue number.

jzacsh’s picture

jzacsh commented
Assigned: Unassigned » jzacsh
Status: Needs review » Closed (fixed)

Thanks @beejeebus for fixing my commit access - committed this patch 65525fe99b5b4ce842fe0149c9e9127285d66fbf to chatroom's drupalconlondon branch.

a.ross’s picture

a.ross commented

Shouldn't it really be REQUEST_TIME instead of time()?

a.ross’s picture

a.ross commented
Issue summary: View changes

Linked to the relevant commit to node.js integration module.