Please develop responsibly with php error reporting set to E_ALL|E_STRICT in php.ini or in your settings.php file.
Strict warning: Declaration of signup_handler_argument_signup_user_uid::query() should be compatible with that of views_handler_argument_numeric::query() in _registry_check_code() (line 2702 of includes/bootstrap.inc).
Patch in first comment.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | signup-strict-warnings-1266026_10.patch | 2.04 KB | jwilson3 |
| #3 | signup-strict-warnings-1266026_3.patch | 2.04 KB | jwilson3 |
| #2 | signup-strict-warnings-1266026_2.patch | 1.41 KB | jwilson3 |
| #1 | signup-strict-warnings-1266026.patch | 645 bytes | jwilson3 |
Comments
Comment #1
jwilson3Comment #2
jwilson3More strict warnings... re-rolled patch.
Comment #3
jwilson3Yet another strict warning.
Re-roll attached.
Comment #4
geert commentedGreat! When will this be included in a build?
Comment #5
jwilson3geert:
The standard process is for anyone in the community (including but not limited to the module maintainer) to download and apply the patch and confirm that the errors are no longer there, to read through the patch to ensure high quality, and coding standards, and then to mark the status as "reviewed & tested by the community". At that point a maintainer may (if he/she wasnt previously interested) add the code to the repository. Then, you'll need to wait for the next stable release, or download the development snapshot.
In short, the first step is to provide a patch review. ;)
Comment #6
geert commentedHello,
Just tried to apply the patch. It is my first time. I get fatal: corrupt patch at line 41
Here is what I did
1- install a git tool from git-scm.com (Git-1.7.6-preview20110708)
2- I create a repository called signup: git init --bare signup.git
3- I download the signup module from git.drupal.org/project/signup.git
4- i put the patch in the signup directory
5 I run git apply -v [patchname.patch]
6- I get fatal: corrupt patch at line 41
What to do next?
thx
Comment #7
geert commentedTo alterv the title back. Sorry
Comment #8
jwilson3Can confirm the patch doesnt apply, Will re-roll the patch...
Comment #9
jwilson3forgot to change status.
Comment #10
jwilson3re-roll.
Comment #11
geert commentedWhen applying, there is an error in the first part of the patch, related to node-settings.inc
the source says:
// Load the default admin form data for new nodes.
if (!$node || !$node->signup) {
$result = db_fetch_object(db_query("SELECT * FROM {signup} WHERE nid = 0"));
the patch says:
// Load the default admin form data for new nodes.
if (!$node || !$node->signup) {
$result = db_query("SELECT * FROM {signup} WHERE nid = :nid", array(':nid' => 0))->fetchObject();
Geert
Comment #12
jwilson3@geert are you sure you're on the 7.x-1.x branch?
Comment #13
geert commented@Jwilson3 Looks that the download from git takes the 6 branch. Found a way around this.
the patch applies and I did some testing. The module still seems to work. There are still strict warnings, but not the ones as mentioned in this issue.
When going to the signup/administer page of a node
Warning: Illegal offset type in isset or empty in views_handler_field_prerender_list->render() (line 53 of C:\xampp\htdocs\Lenske2\sites\all\modules\views\handlers\views_handler_field_prerender_list.inc).Notice: Undefined property: stdClass::$language in _signup_date_get_node_scheduler() (line 112 of C:\xampp\htdocs\Lenske2\sites\all\modules\signup\includes\date.inc).Geert
Comment #14
jwilson3@geert: The errors you're seeing are not Strict warnings, but actual bugs. Also, as soon as you get errors, the best thing to do is try searching for them... In this case, both of those errors have already been reported and are separate issues:
See: #1208224: warning: Illegal offset type in isset or empty and #1190944: Notice: Undefined property: stdClass::$language in _signup_date_get_node_scheduler(), respectively.
Comment #15
sgabe commentedThe patch in #10 applies fine and eliminates the strict warnings.
Comment #16
sgabe commentedCommitted, thanks!