When I add a Date field to a vertical tab group the label on the edit form no longer shows.

D

Comments

finn lewis’s picture

I have the same issue.
Date 7.x-2.0-alpha4
Drupal 7.7

When placing the date field in a vertical tab group, we lose all fieldsets.

This appears to be a bug in core css: http://drupal.org/node/1015798

I am using seven as the admin theme, so I have created a seven subtheme and added the css from the patch on http://drupal.org/node/1015798#comment-3952034

div.vertical-tabs .vertical-tabs-panes fieldset fieldset {
  border: 1px solid #ccc;
  margin: 1em 0;
  padding: 2.5em 0 0;
}
div.vertical-tabs .vertical-tabs-panes fieldset fieldset legend {
  display: inline-block;
}

This fixes it for us.

nancydru’s picture

This also happens when using Field Collection.

[EDIT] Well it may be different. I don't see a label to even theme.

<div id="edit-field-position-collection-und-0-field-position-dates-und-0-value" class="date-padding">
  <div class="form-item form-type-textfield form-item-field-position-collection-und-0-field-position-dates-und-0-value-date">
    <div class="date-date">
      <input id="edit-field-position-collection-und-0-field-position-dates-und-0-value-date" class="date-clear form-text" type="text" maxlength="128" size="60" value="07/01/1991" name="field_position_collection[und][0][field_position_dates][und][0][value][date]">
    </div>
    <div class="description"> Format: 09/27/2011</div>
  </div>
</div>
aidanlis’s picture

Subscribe.

aidanlis’s picture

StatusFileSize
new39.18 KB

It looks pretty ugly as part of a vertical tab group too, image attached.

tike012’s picture

Version: 7.x-2.0-alpha4 » 7.x-2.0-alpha5
Component: Date CCK Field » Code

Bug is still present in alpha5. I can reproduce the problem two ways:

1. "Start Date" and "End Date" labels don't show up, but the surrounding fieldset's (the node field label) does. (Not nested in any other groups)
2. Dates placed inside vertical tab groups have missing labels.

break9’s picture

#1 solved it for me

div.vertical-tabs .vertical-tabs-panes fieldset fieldset legend {
  display: inline-block;
}
karens’s picture

Title: Date label disapears when date field is part of a field group » Date label disapears when date field is part of a vertical tab
Status: Active » Fixed

The title of this issue was mis-leading, this is a vertical tab issue not a field group issue (as in the field group module). #1 indicates this is a core bug, so I don't see that there is anything Date can do.

aidanlis’s picture

Project: Date » Drupal core
Version: 7.x-2.0-alpha5 » 7.x-dev
Component: Code » theme system
Status: Fixed » Active

I'm not sure why you'd mark it as fixed?

Assigning over to Drupal core.

karens’s picture

Project: Drupal core » Date
Version: 7.x-dev » 7.x-2.x-dev
Component: theme system » Code
Status: Active » Closed (won't fix)

There is already a core issue, referenced above. There is no need to create another. This is 'fixed' from the perspective of Date, as in there is nothing for Date to do. If it makes you happier I'll mark it Won't fix.

aidanlis’s picture

Status: Closed (won't fix) » Active
StatusFileSize
new28.37 KB

Sorry to open again, but I don't think the core fix addresses the problem - the styling of a date field is totally inconsistant with the other form elements. See the attached image ... what do you think - maybe we can do better?