support_client CRUD [#1267346]

Comment	File	Size	Author
#6	1267346_6_add_client_crud.patch	8.07 KB	ergonlogic
#2	1267346_2_support_client_CRUD.patch	9.67 KB	ergonlogic

Comment #1

jeremy commented 2 September 2011 at 07:23

Sure, sounds like a simple enough patch...

Log in or register to post comments

Comment #2

ergonlogic

he/him

English

Montréal, Québec 🇨🇦

commented 6 September 2011 at 14:07

Status:

Active

» Needs review

Status	File	Size
new	1267346_2_support_client_CRUD.patch	9.67 KB

Cool, so here's a first pass patch. I've taken the liberty of refactoring support_admin_client_submit() to use a merge query, which avoids erroneous "update" messages.

Alternatively, feel free to cherrypick individual commits from: http://drupalcode.org/sandbox/ergonlogic/1269174.git/shortlog/refs/heads..., if you prefer.

Log in or register to post comments

Comment #3

jeremy commented 6 September 2011 at 18:22

Thanks, I'll take a look at merging this after 6.x-1.5 is released (as I'm only intending to include bugfixes over the current rc1), hopefully tomorrow.

Log in or register to post comments

Comment #4

jeremy commented 22 September 2011 at 12:10

Status:

Needs review

» Needs work

Looking at the patch quickly, I'm not seeing much benefit from this. Is your intention to be calling these functions directly in your own workflow?

It would be preferable to pass a single object or array that contains all necessary fields, rather than an obscenely long parameter string. It would also make sense to define pre and post execution hooks for each activity. While I'm not opposed to the idea, it's still not fully clear to me what will be gained.