Hey guys,

I was surprised just now to see that no one else has posted an issue about this.

Double-clicking on any of the description, alt and title areas next to an uploaded image will open the editable field yet the 'edit' link which displays will only take you to '#' - which looks like a bug due to placeholder code, surely the edit button should do the same thing as double-clicking.

Am I missing something?

Also - is it possible to just force those fields open all the time instead of having someone click on them?

PS - I'm using this module with imagefield on a cck field in drupal 6 with multiple uploads enabled.

Qasim./

CommentFileSizeAuthor
#5 swfupload-edit-title-alt-fix.patch740 bytesaskibinski

Comments

anea02’s picture

anea02 commented

I am experiencing the same issue. I am using this module on two sites - on one it is operating fine, on the other I have this issue. If I find anything I will post back.

I will examine the differences between the two sites.

Adam

designguru’s picture

designguru commented

I'm keen on reading about your findings anea01 - I thought this might be a problem with the module but perhaps its a javascript conflict or something if you have the edit links working on 1 of your websites.

q./

anea02’s picture

anea02 commented

designguru

I believe you are right (that it is a javascript issue). I am working on three sites at once at present. As soon as I come back to that site I'll get you an update. BTW, on a related note (i.e. javascript) - on the same combination of sites as above I implemented the fix in #27 details here http://drupal.org/node/719604 . On one site it fixed the issue, on the other it CREATED the issue. Obviously there are lots of (unknown) dependencies for SWFupload.

What would be most helpful? A list of list of modules from working and non-working sites? A copy of cached javascript files ... ?

Adam

tegneged’s picture

tegneged commented

Hi designguru,

I had the same issue resently and after i examined the javascript I found a minor error in swfupload_widget.js at line 412.

I had to change the click event assignment so it was outside the append before I could get the edit link to work:
So I changed:

find('.wrapper').append($('<a href="#" />').text(Drupal.t('edit')).addClass('toggle-editable').click(function() {
          ref.toggleInput($(this).parent().find('span'), true, file);
          return false;
        }));

to:

find('.wrapper').append($('<a href="#" />').text(Drupal.t('edit')).addClass('toggle-editable')).click(function() {
          ref.toggleInput($(this).parent().find('span'), true, file);
          return false;
        });

Notice the change to:

append($('<a href="#" />').text(Drupal.t('edit')).addClass('toggle-editable'))

I am quite sure that this was what resulted in a faulty behaviour since the dom object was not yet attached to anything in the html when the event was created.

I will try to get a patch up one day soon.
I hope this helps

// Jesper

askibinski’s picture

askibinski commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new swfupload-edit-title-alt-fix.patch740 bytes

#4 works!

Here's a patch I rolled.

Jenechka’s picture

Jenechka commented

#4 #5 works
Thanks guys!