The code that uses this function as a theme callback in hook_menu() doesn't do anything and should be removed. The code in hook_admin_paths() already takes care of making sure that the relevant media gallery pages display in the correct theme.

CommentFileSizeAuthor
#1 media-gallery-node-custom-theme-1270494-1.patch904 bytesDavid_Rothstein

Comments

David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs review
StatusFileSize
new media-gallery-node-custom-theme-1270494-1.patch904 bytes

Here's a patch, untested but it should work fine.

moloc’s picture

moloc commented
Status: Needs review » Reviewed & tested by the community

Tested the edit and remove pages, works as before. The menu.inc file just skip the callback, because it is not found.

kenorb’s picture

kenorb commented

Similar issue with other contrib modules:
#1662848: BookMadeSimple: still uses _node_custom_theme, which doesn't exist anymore
#1662846: Simplenews: still uses _node_custom_theme, which doesn't exist anymore
#1662842: content_access still uses _node_custom_theme, which doesn't exist anymore

lsolesen’s picture

lsolesen commented

@Moloc "The menu.inc file just skip the callback, because it is not found." --> is there something to be fixed there before the patch is committed?

@David_Rothstein You want to commit this yourself? You still have commit access as far as I can tell.

moloc’s picture

moloc commented

The patch fixes the issue. The callback function "_node_custom_theme" does not exist and therefore can not be executed. So the callback should be removed. This patch can be committed.

lsolesen’s picture

lsolesen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.