I see this message all over the place (e.g., /node & /admin/content/node/overview), and often repeatedly on the same page.
The latter can be fixed by simply changing:
drupal_set_message(t('There are no support clients configured/enabled.'), 'error');
to read:
drupal_set_message(t('There are no support clients configured/enabled.'), 'error', FALSE);
in _support_available_clients() on line 2532 of support.module.
The other issue is harder to nail down. From what I can tell, the culprit is in support_db_rewrite_sql(), which calls support_search_available_clients(), which in turn calls _support_available_clients(). IFAICT, this gets run on any node listing page, which I don't believe is the intention.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | limit_error_display_1271038_4.patch | 1.15 KB | ergonlogic |
Comments
Comment #1
jeremy commentedHere's a commit to fix the duplicated messages:
http://drupalcode.org/project/support.git/commit/7bac5f5
The latter is going to be significantly more kludgy to fix in 6.x-1.x, due to how hook_db_rewrite_sql() works. I'm going to go ahead and mark the above as needing to be ported to 7.x-1.x, we can pass this back to 6.x-1.x afterwards.
Comment #2
ergonlogicCould we maybe just wrap that drupal_set_message() in
if (arg(0) == 'admin')? This should eliminate the errors from the front-end of a site, at least. We could still log an error (or maybe warning?) to watchdog, though.Let me know if you're okay with this approach, and I'll put a patch together.
Comment #3
jeremy commentedIt's all going to be a kludge... can you confirm that this solves your problem? If yes, then please attach a patch.
Comment #4
ergonlogicI'm starting to see what you mean...
Anyway, this patch will limit those warning to only admin/support/*, support/* & node/add/support-ticket. It will however log a warning regardless of the path.
Comment #5
jeremy commentedTaking another look at this, it was possibly to cleanly fix this though it required a larger patch:
http://drupalcode.org/project/support.git/commit/0c32659
Needs to be ported to 7.x.
Comment #6
bdragon commented@Jeremy:
As a followup to the #5 patch, something that I suspect snuck in was a fix regarding admin/support/plan_reports vs admin/support/plan_report. There was still a missing instance that needed to be updated for the plan report to work.
Since I ran into this while doing some 7.x stuff, I fixed it in D6.
http://drupalcode.org/project/support.git/commit/662343818e86f36f6bb8719...
Comment #7
bdragon commentedCame along for the ride in my huge push today.
http://drupalcode.org/project/support.git/commit/e87fb05a3d983062782f4d6...