The module has some problems with sites where the site base url looks like this: http://www.example.org/sitename/ (RewriteBase is set to sitename in .htaccess).

ip_login.admin.inc contains relative urls starting with / (e.g. href="/admin)

I've attached a patch that modifies two links to fix this problem.

(Btw. It seems to me that some of these links in the 2.x-dev version are for Drupal 6 while others only work in Drupal 7.)

CommentFileSizeAuthor
#1 ip_login-url_fix.patch1014 bytesmtcs
ip_login-url_fix.patch1014 bytesmtcs

Comments

mtcs’s picture

mtcs commented
StatusFileSize
new ip_login-url_fix.patch1014 bytes

Sorry, the patch file was wrong.
I've attached a new version.

jim kirkpatrick’s picture

jim kirkpatrick commented
Version: 6.x-2.0-beta1 » 6.x-2.x-dev
Status: Needs review » Closed (fixed)

Thanks for the catch mtcs... I've committed a couple of changes based on your patch but using the l() function instead.

This should fix the incorrect base paths on links, and the D7 links in D6... Must have been overzealous with my merging!

The new DEV will be made by the site later on, and I'll be releasing a beta2 very soon.

Also in this commit is some nice code to tell administrators what the site thinks their IP address is.

mtcs’s picture

mtcs commented

Thanks for the quick fix :)