no CVS directory validation for "Administer projects" users -- need better description?

drumm - March 13, 2007 - 01:35
Project:CVS integration
Version:6.x-1.x-dev
Component:User interface
Category:bug report
Priority:minor
Assigned:dww
Status:active
Description

I've got both a DRUPAL-5 branch and DRUPAL-5--1-0 tag on http://cvs.drupal.org/viewcvs/drupal/contributions/modules/job_queue/job..., but I can't create the corresponding release nodes.

#1

dww - March 13, 2007 - 07:42
Title:Can't create releases» document that you should create a project node before adding cvs tags/branches
Project:Drupal.org webmasters» Documentation
Component:Project ownership» Developer Guide
Category:support request» task
Assigned to:drumm» dww

lemme guess, you made your branch and tag *before* you made the project node, right? the {cvs_tags} table was empty for this project, and i think the only way that can possibly happen now is if you add branches/tags when there's no project node at all. i should document this.

meanwhile, i manually added the records you need, so you should be all set.
-derek

#2

dww - March 13, 2007 - 07:51
Status:active» fixed

http://drupal.org/handbook/cvs/quickstart#branch-tag already started with:
"Note: Before you can branch/tag a module, it needs to have a project created."

however, for good measure, i added a blurb to both:
http://drupal.org/handbook/cvs/releases and http://drupal.org/node/100748

#3

dww - March 13, 2007 - 07:56

also added a note to http://drupal.org/node/7765
if there are any other places someone might need to know this, please just edit accordingly. thanks.

#4

drumm - March 13, 2007 - 09:03

Nope, I did-

1. Add to cvs
2. Create project
3. Create branch and tag
4. Attempt to create releases

#5

dww - March 13, 2007 - 16:17
Title:document that you should create a project node before adding cvs tags/branches» no CVS directory validation for "Administer projects" users -- need better description?
Project:Documentation» CVS integration
Version:<none>» 6.x-1.x-dev
Component:Developer Guide» User interface
Category:task» bug report
Status:fixed» active

hehe, i looked more closely, and discovered this tale of woe:

  • http://drupal.org/node/127205/edit contains only "/job_queue/" for the "CVS directory" field.
  • there's a ton of validation for this field, to make sure it should be "/modules/job_queue/" for module projects
  • the description of this field doesn't actually say all the rules that should be followed, and relies on the validation to report the errors.
  • all of the valiation is disabled for people with "Administer projects" permission (since in some cases, we wanted to ignore this validation, and people with "Administer projects" seemed like a safe group to trust with exceptions to the rules).
  • user drumm is in the "administrator" role, which has this perm... ;)

i'm not sure it's worth spending any time on code to change this, other than perhaps fixing the description field to more clearly spell out the rules (which is a little tricky, since the rules are site-specific and depend on admin settings). i could also re-visit if "Administer projects" really needs any exceptions to the rules anymore, since i think i've changed enough other things to make the validation only kick in when it should. for example, projects that aren't in CVS at all (e.g. the "webmaster" and "infrastructure" projects) can now be set so the "CVS repository" is [none], and then nothing is required on the "CVS directory" field).

anyway, sorry for the trouble. i at least fixed the CVS directory on your project, so now commits and tags should be associated with your project node, and the CVS ACL stuff will now work.

cheers,
-derek

 
 

Drupal is a registered trademark of Dries Buytaert.