Closed (won't fix)
Project:
Author Pane
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
8 Sep 2011 at 05:24 UTC
Updated:
19 Sep 2011 at 08:25 UTC
Jump to comment: Most recent file
In Drupal 7 per-content type visibility was re-introduced. #453254: Re-introduce per-content type visibility to block settings
But this module still have own implementation of this feature.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | removed_per_content_type_visibility-1272796-0.patch | 1.67 KB | chi |
| screenshot | 17.03 KB | chi |
Comments
Comment #1
michelleIt's not a bug to not re-use code. It does, however, make sense to do so. I'll leave this active but I'm not working on Author Pane so no idea if/when it will happen.
Michelle
Comment #2
chi commentedComment #3
michelleWell, I can't resist a patch. :) I currently have no dev environment set up so I can't just go and apply this quick. But I should be finished with all my rebuilding within the next few days and will hopefully be able to do this by early next week. If this goes a week with no response, feel free to bump. Stuff falls off my radar pretty easy. :(
Michelle
Comment #4
Scyther commentedWill take a look at that patch as soon as possible.
Comment #5
Scyther commentedIssue with the patch! If you apply it, you can not show the block on a user page if you check any of the checkboxes for per-content type visibility.
Comment #6
chi commentedIt's not the patch issue. Every drupal block cannot be shown if you check any of the checkboxes for per-content type visibility.
Comment #7
michelleIf you check any of the boxes then it won't be shown anywhere except on those node types? That would be a regression, then. I'd say this is a won't fix unless Scyther has a way of making it work properly.
Michelle
Comment #8
Scyther commentedYes that is correct Michelle. node_block_list_alter() is handling that so I can not see a way to get this to work right now.