Breadcrumb Block

* git release branch missing, see http://drupal.org/node/1015226
* README.txt missing
* all functions should have doc blocks on them
* breadcrumb_block_block_info(): indentation error in the array, should always be 2 spaces.

Automated review:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards

sites/all/modules/pareview_temp/test_candidate/breadcrumb_block.module:
 +5: [minor] There should be no trailing spaces
 +29: [minor] There should be no trailing spaces

@CoffeyMachine has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

Hi CoffeyMachine,

I have just reviewed the code in your module and installed and tested it.

There still seem to be some issues around coding standards, they are very minor though. See http://ventral.org/pareview/httpgitdrupalorgsandboxcoffeymachine1273560git for details.

This is quite a simple module with very little code to it, but from what code there is I cannot see any issues, and the module works as described.

I would perhaps expand the readme slightly. Perhaps mention the structure/blocks page where the user can enable the block that this module adds for display.

Hello!

Small and simple module, and does exactly what it says it should do. However, you should fix the small issues pointed out in http://ventral.org/pareview/httpgitdrupalorgsandboxcoffeymachine1273560git

Other than that, looks good to go. Marking as needs work, since this should be a quick fix for you. Will check back when issues have been resolved.

If you say that there are only a few minor coding standard issue left, the correct status is RTBC.

Ah, ok. Sorry about that. Noted!

Your project page is not very detailed (installation, usage ?), please have a look at the tips for a great project page, you may also use HTML-tags for better structure. Same with your readme, make sure it follows the guidelines for in-project documentation.

I'm afraid that this project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed (regarding security and correct api usage skills). However, we can promote this single project manually to a full project.

Function documentation should go like this (according drupal coding standarts/doxygen formatting)

/**
 * Short function description / Implements hook_*().
 *
 * Long function description that can go over multiple
 * lines, make sure to always end a sentence with . ? or !
 * If this is not a hook, you should also document paramters
 * and return values properly (see doxygen formatting documentation).
 */

$delta should either be the full module name or (if you define multiple blocks) prefixed with the full module name.

Leaving RTBC, please fix those issues and I'll promote your project to a full one.
For getting the permission to promote projects yourself, please come back with a *little* bigger module another time.

@kiamlaluno: Please provide this message if you approve an application (see http://groups.drupal.org/node/184389 ):

Thanks for your contribution, CoffeyMachine! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.

klausi - but this applicant should not have the git vetted user role, if I understood patrickd right? It is a too small module.

Well, kiamlaluno granted the git vetted user anyway and I think we should not take it away it this point.

@kiamlaluno: please do not grant the git vetted role for very short projects like this one, promote the sandbox yourself instead. Applicants can come back if they have another project to promote.