Not sure whether to file this here or under send.
Send to a friend module was working prior to installing fivestar.
However when you enable fivestar on a given node content type that also has send enabled on it, send never mails. the send link IS present on the node page displayand when you click it, one is presented with a form to type in a destination email address like it should. however, after you fill that in and then click it to mail, the from returns and no error messages OR confirm messages that a message has actually be sent are displayed like it would if it was successful (or failed).
The minute i disable fivestar on the content type, send does send mail properly as normal.
NOTE: the contact form does mail properly so mail IS working. And the fact that mail works again after fivestar disabled means that mail definitely is not the problem.
Somehow these 2 modules are stomping on eachother and i'm not sure which one is to blame. That's actually quite odd because i don't believe fivestar emails anything.
Anyway, the best thing to do might be to try it locally and see what i'm talking about.
NOTE: if i have the fivestar CCK field enabled on the node type, it does NOT mess up the mail. Only when using the nodeapi fivestar which appends that functionality to a node type does send not work. So that should help narrow down the problem.
HOWEVER: and this probably should be another bug. When I DO enable fivestar CCK field on a node type, it does NOT effect send module BUT it spits out a series of error messages whenever you edit and submit the form. I think they might be harmless but i'm not sure. The minute i delete the CCK field on the type, the error messages go away.
thanks
Comments
Comment #1
quicksketchI think this was part of http://drupal.org/node/137887. Fivestar had been causing SQL errors on node update/insert which probably threw off send module. So yes, it's our fault... sorry ;)
Should be fixed now. 1.5 release is coming after I finish with the queue. Thanks!
Comment #2
newdru commentedthanks quicksketch...
i'll download, install and give a whirl.
fwiw, i mentioned two different bugs in my original post:
1) fivestar nodeapi tripping up send
2) fivestar cck field spitting out errors.
i can't tell from your post if both or only one (and which one) of those are fixed in the new update.. let me know if you can thanks
Comment #3
quicksketchI think they were both caused by the same problem actually :)
1.5 has been released and is available for download.
Comment #4
Anonymous (not verified) commentedThis problem still exists with me on 1.8.
I read the other thread, and found this one more appropriate, or down to the problem, so i'll un-duplicate it, and see what you think..
On my Drupal 5.5, Send 1.x-dev, and Fivestar 1.8, when trying to send an Image node (not even through CCK), the send module won't do anything.
I noticed that the $node is fully displayed under the send page, including fivestar widget and all, but clicking the Send button does nothing. Even if you leave the TO/FROM email fields (which are required) empty, you get no response or warnings or errors.
Digging deeper, i found that the problem can be pinpointed down to the function _send_body($message, $nids, $module, $mode) function at the line
$text = node_view($node, false, true, false);I'm willing to help debugging more.. Feel free to ask for more information.
Now, until it's fixed, i need to send the node at least without the fivestar widget. So, as a temporary solution for anyone else, trying to disable it there with a $altered_node = call_user_func('xushi_alter_node', $node) and adding the IF statement below didn't help as the widget was always still in the content after being returned from node_view();
A hack is to override node_view, and add the IF there instead...
$text = node_view($node, false, true, false);becomes
$text = send_node_view($node, false, true, false);copy over the function from node.module to under this one, and add
Comment #5
Anonymous (not verified) commentedSorry, forgot to change it's status.
Comment #6
quicksketchClosing after lack of activity. If this problem still exists, I'd suggest asking in the send.module queue. The Drupal 5 version of Fivestar will be end-of-life shortly.