After installed this module and configured it with Flickr "API Key" and "API Shared Secret". For a test I inserted the filter below to a node page
[flickr-photo:id=230452326,size=s]
It seems work well.

But if I insert a photoset filter, for example:
[flickr-photoset:id=72157594262419167,size=m]
It's a blank, nothing shows up.

Anything wrong or is there a bug?

CommentFileSizeAuthor
#2 flickr.patch1.08 KBmbaker.pdx

Comments

mbaker.pdx’s picture

Assigned: Unassigned » mbaker.pdx

Confirmed. Working on a basic patch.
The issue seems to be that theme_flickr_photoset is not implemented.

mbaker.pdx’s picture

Status: Active » Needs review
StatusFileSize
new1.08 KB

I've implemented the api call flickr_photoset_get_photos(). Any reason not to do this?
I'm then using it in theme_flickr_photoset().

Attaching patch for your perusal.

drewish’s picture

Status: Needs review » Fixed

it should be good to go.

astra’s picture

There are two functions in the frickr.patch. I manuallt put the first function to frickr/frickr.inc and the second function to frickr/frinckr.module, it seems work.

drewish’s picture

astra, you shouldn't need this patch. i've committed other code that fixes it. please grab the new release and try that. if you run into problems please open a new issue.

astra’s picture

Installed the new release Flickr-HEAD 14-April-2007 and have a test, for the example:

[flickr-photo:id=230452326,size=s]
[flickr-photoset:id=72157594262419167,size=m]

'flickr-photo' displays one picture, it seems ok. But 'flickr-photoset' still displays ONLY one picture, not a set of photo's. Something wrong?

andrewlevine’s picture

in flickr_filter, the photoset will only display the primary image of the set. the image is linked to the flickr page of the photoset.

drewish’s picture

Title: Flickr: problem to filter photoset » Show multiple photos in photoset
Component: Code » flickr_filter
Category: bug » feature
Status: Fixed » Active

Okay, I gotcha. That was originally one of the things I'd planned on doing with the filter. I'd like to add a bit more syntax so you can specify a range of photos to show, 1..n to show them all or -2..n to show the last two. something like that.

eagereyes’s picture

I was also looking at the Flickr module for that same feature. The embedded images could all link back to their Flickr pages within the photo set, so that the user can then click through the other images in the set. Looking at the URL for an image within a photoset, that doesn't seem to be particularly tricky.

rockgeek’s picture

Ah ha - explains it!

However on my sets (experiemented with others and ok) it says:

* Flickr error 1: Photo not found
* Flickr error 1: Photo not found

Why could this be?

thanks.

pomata’s picture

Had the same problem, I've altered:

function flickrfield_field_formatter($field, $item, $formatter, $node) {
 if($item['id'] != ""){
  require_once(drupal_get_path('module', 'flickr') .'/flickr.inc');
  switch ($item['type']) {
    case 'photo_id':
      $photo_data = flickr_photo_get_info($item['id']);
      $img = flickr_img($photo_data, $formatter);
      $photo_url = flickr_photo_page_url($photo_data['owner'], $photo_data['id']);
      return theme('flickrfield_photo', $img, $photo_url, $formatter, $photo_data, $node);
    case 'set_id':
      $photo_data = flickr_photoset_get_info($item['id']);
      $img = flickr_img($photo_data, $formatter);
      $photo_url = flickr_photo_page_url($photo_data['owner'], $photo_data['id']);
      return theme('flickrfield_photoset', $img, $photo_url, $formatter, $photo_data, $node);
  }
 }
}

see the if($item['id'] != ""){ statement addition

good luck

Anonymous’s picture

Status: Active » Closed (fixed)

please follow the conversation over @
http://drupal.org/node/195188