Okay, I'm moving my patch to a new bug, since some people just don't seem to get it.

For a little bit of history to this bug, see this comment: http://drupal.org/node/108850#comment-201469

The title pretty much sums it up. (There is also a conflict with a pid field in the comment tables that Morbus already handled, and I don't believe I've interfered with.)

Also, I found that I overlooked something in my previous patch to fix this problem that was causing errors to show up in watchdog and e-mails to be sent with incomplete titles. This patch corrects that. Hopefully there isn't anything else I've overlooked.

CommentFileSizeAuthor
#3 casetracker_3.patch22.83 KBJürgen Depicker
casetracker_2.patch6.13 KBoadaeh

Comments

Lityi’s picture

Lityi commented

I promise I will drink all night on your honour, if you make this patch for 5.x!

oadaeh’s picture

oadaeh commented

The site I created the patch for currently runs Drupal 4.7. I have plans on upgrading that site to Drupal 5 (and the modules as well). At that time or before, I will need to create the patch for version 5 of casetracker. I believe, however, it will be a different bug that will require a different patch and consequently additional troubleshooting. I'm not looking forward to that as I am over-tasked already.

I don't know when I will be able to get the upgrade done, as I have quite a bit of custom code, and I'm considering converting a lot of profile fields to CCK fields (which will also impact the custom code). It could be as early as this week or next that I start on it, or it could be as late as May. It just depends on how my other work stacks up.

Jürgen Depicker’s picture

Jürgen Depicker commented
StatusFileSize
new casetracker_3.patch22.83 KB

On my site (4-7) the comment patch you talk about probably didn't do what it was supposed to, since it didn't work...
So I digged through the code, line by line, and replaced all pid or prid with ctprid, and altered two tables accordingly:
(must be done by hand before using the new code)

alter table `casetracker_case` change `pid` `ctprid` int (10)  DEFAULT '0' NOT NULL;
alter table `casetracker_comment_status` change `pid` `ctprid` int (10)  DEFAULT '0' NOT NULL;

I am not sure my patch format is perfect, it's produced with WinMerge and I hope it is fine. It includes the diffs for casetracker.module, casetracker_views.module and casetracker_mail.module. When I start using xmlrpc, I'll post a patch for that one too.

I don't know how to create an update instruction to make the alteration of the tables automatic. It may also be that you people disagree with my alteration. But at least, this clears up the confusion, and the module works in all cases.

oadaeh’s picture

oadaeh commented

The problem isn't with the database table field names, but with the web form field names. My patch doesn't alter the database, it alters the web form. Changing the database field names is fine and may help with making the code and such more understandable, but it is unnecessary for resolving this problem.

jmiccolis’s picture

jmiccolis commented
Status: Needs review » Closed (won't fix)

Casetracker is under new management and there are no plans to work on the 4.7 branch.