At one point there was discussion about adding in property_info callbacks for entity framework. #1117464: Search API integration comments 18-22 or so.

This patch was never committed. The patch didn't go far enough to create the correct mappings for all the values. Attached is a patch, review needed, that will add correcty entity property info to geofield.

CommentFileSizeAuthor
#8 1285176-geofield-property-info.patch3.61 KBwesnick
#3 entity-integration-1285175-3.patch2.79 KBgagarine
property-info-callbacks.patch2.85 KBwesnick

Comments

gagarine’s picture

gagarine commented

There is a 7.x-1.x-entity-integration branch see http://drupal.org/node/1117464#comment-4497092.

I keep this open, I think this is a separate issue and the '7.x-1.x-entity-integration' branch should be merged in the main branch or your patch committed.

#1153480: geofield_field_info should set a property_type was closed as duplicate.

gagarine’s picture

gagarine commented
Status: Active » Needs review
gagarine’s picture

gagarine commented
StatusFileSize
new entity-integration-1285175-3.patch2.79 KB

The changes made by David Peterson but against 7.x-1 branch to avoid merge conflicts.

mollux’s picture

mollux commented

sub

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
mollux’s picture

mollux commented

is there news when the patch will be committed?

Brandonian’s picture

Brandonian commented

I'll take a look at it during the next round of updates.

wesnick’s picture

wesnick commented
StatusFileSize
new 1285176-geofield-property-info.patch3.61 KB

Attached current version of the patch that I am using.

davidseth’s picture

davidseth commented

The patch at #8 looks good. More features then the one I initially had in place at #1117464: Search API integration.

I will commit this with the latest dev release of geofield '7.x-1.x-entity-integration' branch soon.

Cheers,

David

davidseth’s picture

davidseth commented

Okay, just pushed up changes from #8 to http://drupal.org/node/1087170/git-instructions/7.x-1.x-entity-integration branch. Thanks @wesnick

Brandonian’s picture

Brandonian commented

davidseth, I'm planning on pushing another release soon on the main branch. Is the entity-integration branch at a point where it's stable enough to merge into the main branch? Is there anything I can do to help facilitate that?

I'll be on IRC (Brandonian) all day, ping me if we need to chat.

Thanks all for the hard work on this branch.

davidseth’s picture

davidseth commented

@Brandonian it is good. I have been using it in a number of projects and really all it is doing is exposing some additional callbacks to the Entity module so any potential for instability is *very* small. So please, go ahead and role it into the main branch. That would be great! Thanks.

Brandonian’s picture

Brandonian commented

@davidseth, I had trouble merging branches between the two b/c of some recent developments on the main branch, but I think I pulled in everything properly by hand on the last commit on the main branch. Can you confirm that everything look ok before marking this ticket fixed?

gagarine’s picture

gagarine commented

@Brandonian I compared the patch from #8 with your commit and see no difference. I'm curious if this is compatible with Search API spatial.

davidseth’s picture

davidseth commented

#13 Looks good. Thanks @Brandonian

gagarine’s picture

gagarine commented
Status: Needs review » Reviewed & tested by the community

sound we can marked as reviewed. I let Brandonian close the issue.

Brandonian’s picture

Brandonian commented
Status: Reviewed & tested by the community » Fixed

Marking as fixed. Thanks guys.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.