Closed (fixed)
Project:
GCal Events
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Sep 2011 at 16:07 UTC
Updated:
29 Apr 2013 at 16:10 UTC
It's a big strange that the viewing of the gcal event needs a filter_access check. How would any user actually use the selected input format to simply view the gcal events block?
This is a simple patch to remove the filter_access() call from the display function.
After removal of the filter_access check, the block will display to everyone with whatever input filter was selected without the need to check if they have editing access to that filter or not, which it should never care about.
| Comment | File | Size | Author |
|---|---|---|---|
| gcal.diff.txt | 660 bytes | endiku |
Comments
Comment #1
jdwfly commentedI'm not sure why this check was in there, but it would seem to me that you are correct that the user viewing the page isn't inputting the data for the block. I'm good with removing it as I don't think it implicates any security issues.
Comment #2
jdwfly commentedRemoved this code from dev version.