date_repeat_type() is no more

CommentFileSizeAuthor
date_repeat_type+is+no+more.patch1.3 KBcasey

Comments

joelstein’s picture

Status: Needs review » Postponed

Good find! It appears date_repeat_type was changed sometime after the Date 7.x-2.0-alpha4 release.

However, your patch will not work with the Date 7.x-2.0-alpha4, since in it date_is_repeat_field() requires a second $instance parameter. To keep things backwards compatible, I passed along the instance, which will work with both versions.

Committed: http://drupal.org/commitlog/commit/17454/7e029c3127f701cefd1f328e3618e59...

Once Date issues a new release, I'll remove the backwards-compatible fix and release a new stable version of this module. For now, you can use the latest DEV.

dnotes’s picture

Status: Postponed » Active

Looks like the time has come. :) Nice module.

Actually date 2.0-RC1 has a bunch of changes, including a much nicer ui for date repeats. Hope they didn't change something you're depending on.

Daedalon’s picture

With Date 7.x-2.0-rc1 (and Views 7.x-3.0) I can't use Date Repeat Instance anymore. It breaks Views that show events with dates. They return 500 - Internal Server Error. Disabling DRI fixed the Views. Haven't checked if this occurred already with Date 7.x-2.0-alpha5 or alpha4.

bachomp’s picture

Same issue.

Drupal: 7.10
Date module: 7.x-2.x-dev (Jan 01)
Views module: 7.x-3.0 (2011-Dec-18)
DRI module: Dev commit as per comment #1

wipeout_dude’s picture

I am having the same issue with the current "stable" versions of views and date..

I desperately need this module for a project because its seems to me absolutely the right way to handle the problem it solves.. If I was a coder I would gladly help but all I can do is appeal to those who can to update this to work with the new versions of date and views..

Thanks..

joelstein’s picture

Status: Active » Fixed

I believe this original issue is now fixed.
http://drupal.org/commitlog/commit/17454/f577f60c7ab5a2ae6be35884168d066...

I cannot reproduce the errors the new comments make mention of. If the errors persist, please open a new issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.