Closed (fixed)
Project:
File Entity (fieldable files)
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Sep 2011 at 19:39 UTC
Updated:
15 Mar 2012 at 18:58 UTC
Jump to comment: Most recent file
Comments
Comment #1
dave reidComment #2
amateescu commentedJoining the Media party for a while and I'm taking this issue as my first 'victim' :)
Comment #3
effulgentsia commentedCross linking #1051090: Revamp file view modes: migrate media_small to teaser, media_large to full, media_preview to preview; deprecate link & original for anyone interested, but that one's gonna be a bit harder, since it will need to retain, but deprecate, existing view modes in addition to adding new ones.
Comment #4
amateescu commentedInitial patch that does only what's mentioned in the OP.
Should we also change the 'default' view mode throught the module with the new 'full' view mode in this issue/patch?
Comment #5
dave reidThe default parameter of file_view() should be 'full', but I don't think anything else throughout the module needs to be changed?
Comment #6
effulgentsia commentedUpdates some functions to default the $view_mode parameter to 'full', and removes the stray reference to 'media_preview'.
Comment #7
amateescu commentedHeh, that's what I was talking about in #4.
Comment #8
effulgentsia commentedYep. You were right, which prompted Dave and me to look more into it. Thanks for catching that.
No need to remove the preview entirely. We can output a link to the file. Media can then alter this into file_view_file($file, 'media_preview'). This patch fixes that.
Comment #9
dave reidCommitted #8 with a minor tweak to match up the default weight of $form['preview'] with file_entity_field_extra_fields().
http://drupalcode.org/project/file_entity.git/commit/f38dfa5
Thanks effulgentsia and amateescu!
Comment #10
effulgentsia commentedFollow-up: #1296268: Add Preview and Teaser view modes
Comment #12
nedjoThe 'custom settings' property of this view mode was set to FALSE, meaning that the view mode can't be configured. Was this intentional? If so, why? It seems that as a result the view mode is not used at file/%file and default is used instead, presumably because of the test for 'custom settings' in file_displays(). Should 'custom settings' be set to TRUE instead?
Comment #13
nedjoUpdates needed for each media provider module. Initial issues posted for media_youtube and media_vimeo.
Comment #14
dave reid@nedjo: View modes can be enabled to be configured on the 'Manage display' tab regardless of the boolean in hook_entity_info(). Moving back to closed (fixed).
Comment #14.0
dave reidUpdated issue summary.