D7 version of Update Status Detailed Email

Hi,

Sorry, just noticed this. I'm looking into upgrading it. I'll look at your upload. Thanks!

Is this D7 port confirmed to be working? Great functionality this module has.

Not yet. If you want to download and test Denes' port and report back the results, that would be helpful.

I'll try to do some testing this week, after getting my laptop setup. I started playing around with some code, so hopefully I'll post something soon.

...better title for our dashboards + tags ;)

Here's the tarball from #1 as a patch. Yet untested.

Works fine, the formatting could be improved but that's no major. Let's get a branch ready for 7.x.

@davidhernandez - when you have a chance, could you please branch for 7.x-1.x and commit the patch above to it (with --author="denesszabo <denesszabo@582668.no-reply.drupal.org>")?

Once we have a 7.x-1.x branch, it'll be easier for people to test and contribute patches. (Could roll this out to a bunch of 7.x sites, but having it only available for 6.x via Drupal.org makes doing so fiddly, and I'd rather not split work off to my own repo if I can use git.drupal.org and issue queue patches.)

Leaving at needs work because I haven't had a chance to test it extensively, and I can see room for improvement (formatting, email subject).

Customising the message subject is good, but replacing the existing default "New release(s) available for !site_name" with simply "Updates available" is not ideal if you have >1 sites to maintain.

This restores the default Update module subject, and adds the URL as well (if you run dev/staging/live sites and don't change the name on each, this is nicer).

This patch might be worth backporting to 6.x.

Getting back to this. I'll take a look.

Getting back to this. I'll take a look.

...any news on the 7.x branch? I could really use a 7.x-dev.

...in the meantime here's a tarball (d.o renames it to .tar_.gz for security reasons) with both #10 and #12 applied against latest 6.x-1.x-dev.

...and since we don't have a 7.x branch to file issues against, here are two things:

1. In the site's Available updates settings page (/admin/reports/updates/settings) I get this error:

Notice: Undefined variable: langcode in update_detailed_email_form_update_settings_alter() (line 28 of /var/www/mysite/sites/all/modules/update_detailed_email/update_detailed_email.module).

2. The "Subject" field in the same page is located underneath the "Save configuration" submit button:

Needs moar blur Klonos, only took me two beers to read that company name ;)

@davidhernandez: thanx for the 7.x branch David. Lets call this fixed then, since this issue was about an initial 7.x version and file separate issues against that branch. Shall we?:

#1921606: Undefined variable: langcode in update_detailed_email_form_update_settings_alter() (line 28 of update_detailed_email.module
#1921598: The "Subject" @ admin/reports/updates/settings is underneath "Save configuration" button - conflict with update_advanced

@grobot: lol :D ...seriously now Chris?

Could you please create a separate issue and upload your patch form #12? I would do it myself, but I don't want to get the credit for it ;)

Done. Please ignore patch in #12, it's now #1921946: More informative email subject (site name & URL)..

Thanx Chris ;)

Re-opened this because we want the patch from here committed so we have not just a 7.x-1.x branch, but a 7.x-1.x branch with .info saying 'version = 7.x' and the other fixes by Denis.Szabo (mostly!) in this thread.

Rerolled so that it applies to 7.x-1.x branch, which doesn't contain the token additions from #1426272: Allow token replacements in subject line..

Sorry for update spam folks, making sure we can roll this out entirely from drush make. I promise to try and always use github gists while testing in future :)

The indentation in these places seems a bit odd:

+          $row .= theme('update_detailed_email_message_version',
+                    array('version' => $project['releases'][$project['recommended']],
+                          'title' => 'Recommended version:')
+          );

+          $row .= theme('update_detailed_email_message_version',
+                     array('version' => $project['releases'][$project['latest_version']],
+                           'title' => 'Latest version:')
+          );

+          $row .= theme('update_detailed_email_message_version',
+                    array('version' => $project['releases'][$project['dev_version']],
+                          'title' => 'Development version:')
+          );

+          $row .= theme('update_detailed_email_message_version',
+                    array('version' => $project['releases'][$also],
+                          'title' => 'Also available:')
+          );

Sorry for the delays. I haven't had a use case for this module in a while, so it has been hard getting the time to work on it. I'd be fine with adding some else as a maintainer. If you are interested, open an issue.

Setting text/html makes the plaintext output all run together, so I'm just switching to plaintext for now - it's ugly but serviceable.

Updated patch :)

...nitpicky, I know but the indentation in places like this:

+          $row .= theme('update_detailed_email_message_version',
+                  array(
+                    'version' => $project['releases'][$also],
+                    'title' => 'Also available:'
+                  ));

makes more sense like so:

+          $row .= theme('update_detailed_email_message_version',
+                        array(
+                          'version' => $project['releases'][$also],
+                          'title' => 'Also available:'
+                             )
+                       );

Agreed. I'll try to remember to include that if I roll another version of this patch before this gets committed, but I'm not rerolling just for whitespace :)

Coding standards and nice HTML emails can be separate issues, this issue should concentrate on a basic functional D7 port I think.

Agreed! Lets get the basic functionality and then we can polish ;)

Committed the last patch into 7.x for testing.