The Fullname field looks good, but when I try and enter a name with anything other than alpha characters (eg an apostrophe or a hyphen) it's rejected. So I can't enter my good friends Gavin O'Reilly and Mary-Jane Osborne-White :(

Comments

rconstantine’s picture

rconstantine commented

Ooo, good catch. I obviously failed to take those into account. I'll adjust the regular expressions as soon as I get a chance.

While we're at it, are there any others you can think of? It seems that PHP doesn't currently support the simple regex for international letters (in unicode). I can't remember what the regex would be, but it was really simple and allowed all of the accent-marked letters, as well as Chinese and other characters, all in one simple phrase. Perl does have support for it, just not PHP's implementation of the perl-style regex's.

So for now, I'm only supporting the English alphabet. Eventually, I'd like to provide a drop down to select a country of origin, which will select from a list of possible regex's for validation. Patches are welcome.

But I'll add the hyphen and apostrophe as soon as I can. Good catch.

adam_b’s picture

adam_b commented

Sorry, I'm a humble integrator/manager rather than a developer... regexp's give me a splitting headache. But my initial reaction would be to ask why control the content entry at all? It's not done on normal text fields, so I'm not sure what it adds here.

And a country-based drop-down menu which controls allowable exceptions is asking for trouble - what about my other good friends Eva Janaček and Nhãn Đuc Nguyen who live in London but insist on using the correct Czech/Vietnamese accents for their names?

rconstantine’s picture

rconstantine commented

Update: I had hoped to get to this today. Should be able to get to this by next Wednesday.

rconstantine’s picture

rconstantine commented
Status: Active » Fixed

Fixed. Get the dev release dated today or later.

rconstantine’s picture

rconstantine commented
Assigned: Unassigned » rconstantine
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
csc4’s picture

csc4 commented

The dev version has fixed the hyphenated surname problem but validation no longer says 'first name' required - it just says 'field is required'