Download & Extend
Version Control / Project* integration » Issues

Support marking an issue as fixed via a commit

Posted by boombatower on September 27, 2011 at 7:02am
Project:Version Control / Project* integration
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

Split off from #493074: Back-link to the commit as a comment on the related issue..

Possible methods for marking an issue as fixed via a commit:

  • Provide per-project setting that marks issues as fixed when related commit is made. Most of contrib tends to work this way, but we can simply default to false just to be safe.
  • Use special syntax in commit message for closing issues (or git notes) such as github style "closes #".

Or of course, not at all.

Login or register to post comments

Comments

#1

Posted by dww on September 27, 2011 at 7:43am

I prefer special syntax over a per-project setting (even if it defaults to false). I don't think we want to be automatically marking things fixed on every commit. The human should somehow decide the issue is fixed or not on a case-by-case basis, and either reply at the issue themselves, or at least format their commit message to indicate they intend for the issue to be closed.

In terms of the specific syntax, seems reasonable to adopt the de facto Github standard.

Although "closes #x ..." is not as ideal for harvesting commits when writing release notes (e.g. with http://drupal.org/project/grn). For that "fixed #x" would be better. Maybe we should just support a couple of different prefixes and give maintainers freedom to decide how they want to use this. Or maybe we should patch grn to re-write "closes #x" to "Fixed #x" (or just "#x") or something. ;)

Anyway, this would be a slick feature, and should be quite easy to implement once #493074: Back-link to the commit as a comment on the related issue. lands. I'd normally call this "postponed" since no one should start writing code for this until #493074 is in -- but in this case it seems okay to leave the issue open for further discussion on syntax vs. setting, and what syntax we want assuming we're going to go that route.

Thanks,
-Derek

nobody click here