the attached patch is a d7 port of #1 in #1038032: Pubsubhubbub bug
problem:
I found out that, each time a pubsubhubub notification is sent by a hub to a subscriber, the subscriber issues a new subscribe request to the hub.
Why ? If you look into the import function of FeedsSource, you will see that at the end, it calls the save method. This save method calls, for each importer, its sourceSave method. When you're using pubsubhubbub with FeedsHTTPFetcher, it will therefore call the sourceSave method of FeedsHTTPFetcher, which will call the subscribe method to the hub, generating a subscribe request that is not needed.
works for me so far
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | push_hub_bug_d7_2.patch | 1.21 KB | dasjo |
Comments
Comment #1
dasjosubscribe didn't work anymore
Comment #2
twistor commentedThis needs to check the subscriber_id, as well as, check that the source url has changed.
Comment #3
voxpelli commentedThis is getting fixed by #2510260: Fix pubsubhubbub. as well, which is currently in need of review. Not sure if we maybe want to close this as a duplicate and focus the effort on that issue instead?
Comment #4
bluegeek9 commentedDrupal 7 reached end of life and the D7 version of Feeds is no longer being developed. To keep the issue queue focused on supported versions, we’re closing older D7 issues.
If you still have questions about using Feeds on Drupal 7, feel free to ask. While we won’t fix D7 bugs anymore, we’re happy to offer guidance to help you move forward. You can do so by opening (or reopening) a D7 issue, or by reaching out in the #feeds channel on Drupal Slack.
If this issue is still relevant for Drupal 10+, please open a follow-up issue or merge request with proposed changes. Contributions are always welcome!