Recurring fee cancel function failing with authorize.net ARB

I confirm this issue. On version 6.x-2.0-beta1 error is line 761 /uc_recurring/uc_recurring.module

Edit: And the problem is apparently with a target file, not this file. See below.

If someone has time to try the fix here before I do, please post.

I confirm the fix here worked for 6.x-2.0-beta1. I've updated the line numbers to match 6.x-2.0-beta1 version of uc_recurring/modules/uc_recurring_hosted/uc_recurring_hosted.module:

Fixes:

line 446: function uc_recurring_hosted_authorizenet_arb_cancel($order, $fee) {
line 473: if (!empty($order->order_id)) {
line 474: uc_order_comment_save($order->order_id, 0, t('Authorize.Net: Subscription @subscription_id cancellation failed.
@error - @text', array('@subscription_id' => $subscription_id, '@error' => $data['code'], '@text' => $data['text'])), 'admin');
line 479: uc_order_comment_save($order->order_id, 0, t('Authorize.Net: Subscription @subscription_id cancelled.', array('@subscription_id' => $subscription_id)), 'admin');

Would be nice to pinpoint when this problem arose and get all subsequent appearances.

I've tested and verified that the above fix works.

PLEASE USE THE MOST CURRENT PATCH BELOW

Here is the patch.
PLEASE USE THE MOST CURRENT PATCH BELOW

Accidental post -- ignore

Vim, thank you so much for this patch. Line 20 doesn't look quite right, and I think you meant to write what you have in the patch at http://drupal.org/node/1372432. I'm going to test this patch soon.

Thanks for catching that Shaun -- you're right about line 20.
Also currently the patch only works when it's run from sites/all/modules/uc_recurring/modules/uc_recurring_hosted
According to drupal standard practice should that be drupal root OR sites/all/modules/module-to-be-patched as well?

Your patch here: http://drupal.org/node/1372432#comment-5546564 works great. Tested against 6.x-2.0-beta1. Thank you! I had some unhappy customers there...

@ferdinand This problem arose for me when upgrading PHP to 5.3.x which is unforgiving about the pass by reference/value error in the function definition.

@vmi how about just copying your patch at http://drupal.org/node/1372432#comment-5546564 here? It's relative to the contrib module root (.../uc_recurring in this case), as per Drupal standard, so looks good. I'd copy your patch here, but then it might look like I wrote it ;). I'll mark this Reviewed and Tested after you copy over.

I thought there was a difference in lines for d6 vs. d7...n/m

Yep, you're right, but the patch applied anyway with an "offset". If you re-roll for D6, it'll be even better (and not spit out a .orig file).

Hopefully this patch is better.

good stuff.

committed, thanks.

I remarked this as active because looking at the latest release of 6.x.2.x-dev (released on April 25, 2012), this patch doesn't exist in it. I am about to apply it now for myself.