I would just like to be able to select the Hostname in my admin views for orders so I'm submitting this patch.

CommentFileSizeAuthor
#13 1293894-commerce_expose_hostname_or_ip_address_to_views_field_handlers-11.patch1.26 KBandyg5000
#13 Screenshot 2016-04-22 11.33.03.png21.94 KBandyg5000
#9 1293894-commerce_expose_hostname_or_ip_address_to_views_field_handlers.patch1.09 KBandyg5000
#1 ExposeOrderHostnameToViews-1293894.patch780 bytesASupinski

Comments

ASupinski’s picture

ASupinski commented
StatusFileSize
new ExposeOrderHostnameToViews-1293894.patch780 bytes

patch file

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Active » Needs review

Updating status.

bojanz’s picture

bojanz commented

There might be legal repercussions based on who you show the hostname to, see: http://drupal.org/node/743320#comment-2848090

alberto56’s picture

alberto56 commented
Status: Needs review » Reviewed & tested by the community

Thanks, this is what I needed. The patch applies with some fuzz to the latest version and works as expected.

ASupinski’s picture

ASupinski commented

Any chance of getting this into the main line? I understand there could be issues with exposing information in the wrong way but there is a lot of content that shouldn't be exposed to all users that doesn't mean admins don't have a reason to be able to access it.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: ExposeOrderHostnameToViews-1293894.patch, failed testing.

Marko B’s picture

Marko B commented
Issue summary: View changes

I understand privacy issues, but this should be the reason for not having it. For example IP list can be used to help with IP fraud detections and should be accessable for users with proper levels of permissions.

Marko B’s picture

Marko B commented

Anyway this patch will enable you to have IP address exposed in Views field. Not know why it failed testing, dont know anything about patch testing at this point?

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 1293894-commerce_expose_hostname_or_ip_address_to_views_field_handlers.patch1.09 KB

Updated patch to include order revision IP as well. I'm in favor of committing this (obviously) because we're not adding the field to any views, but providing the ability to do so at your own risk.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

What if we provide obfuscation of the IP address when displayed? Like as an option. That way it can be used when exporting a report, but obfuscated when displayed on the website UI.

Then this could be enabled by default.

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented

What about updating the view handler descriptions to have a notice that says exposing hostname/ip may be against PI laws in some countries? I don't really know why you'd ever want an obfuscated IP. The reason I had to create this is because site owners need the ability to see the IP when reporting fraudulent orders.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

That works for me.

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
StatusFileSize
new Screenshot 2016-04-22 11.33.03.png21.94 KB
new 1293894-commerce_expose_hostname_or_ip_address_to_views_field_handlers-11.patch1.26 KB
Marko B’s picture

Marko B commented

Looks good. great.